Re: 'g' in the group buffer still very slow

[kai.grossjohann@uni-duisburg.de (Kai Großjohann)]

Martin Rohde <martin.rohde@gmx.de> writes:

> Sorry, I mixed some things up.
> All it saves is the sending of "MyNOOP". It is wrong to speak of
> "saving time". 

Ah, it saves sending that command!  Okay, I completely missed that.
That's a minor point, but it *is* an advantage.

> It just saves the additional code in nntp-open-connection, that's
> why I prefer it. But the other version works as well, so if you're
> prefering your way, I can send you the working patch, too.

No, now I'm convinced that the no-MyNOOP way is better.  So I agree
with you.

> Yes, but i couldn't see a 
>
> (make-local-variable nntp-open-connection-function) 
>
> anywhere. Furthermore, I am not in a special buffer, when I check it
> (or am I?), so that's why I asked.

Whee.  Well, err.  The Gnus backend code is pretty convoluted, and I
believe any number of wonders that can be done with nnoo.

Ah, and nntp-open-connection-function is defvoo'd, not defvar'd.  That
explains it all.  I started to look in defvoo and then in nnoo-define,
but I get lost in a twisty maze of little backquotes...  Anyhow, I'm
almost sure that nnoo has some magic to make the variable local.

Anyone?

> I thought, it would make the start of gnus a bit faster when you are
> using nntp-open-network-stream, because otherwise you would still
> have the delay from nntp-accept-response when nntp-send-command is
> called for the first time.

Hm.  This happens if the first command doesn't produce a response,
right?  Anyhow, it's not so important.  Just leave it like that but a
comment (connections created with nntp-open-network-stream will never
echo; don't bother checking for echoes there) would be nice.

>> Secondly, and this is the logic part, the check-for-echo variable
>> starts out as nil.  I didn't look very closely, but I thought that the
>> echo check is skipped when the variable is nil...
>
> Its global value is nil, but in nntp-make-process-buffer it is
> initialized as
>
> (set (make-local-variable 'nntp-process-delete-echo) t)
>
> The (defvar nntp-process-delete-echo nil) ist just a dummy
> declaration (because of "free variable"-warnings). For it has to be
> checked locally in the server-buffers, it doesn't matter, what its
> global value is, as you explained before. 

What do you think about making it (defvar nntp-process-delete-echo t),
then then, in nntp-make-process-buffer, to just do
(make-local-variable 'nntp-process-delete-echo)?

It might make it a little bit clearer what is the default value of the
variable, so outsiders have a better chance of understanding the code.

Just my two cents.

In general, this is good stuff!
-- 
~/.signature is: umop ap!sdn    (Frank Nobis)