Re: spam.el: asking about removing spam-use-BBDB

[david.goldberg6@verizon.net (Dave Goldberg)]

>> I'll support the BBDB backend to spam.el.  I just need to fix the
>> `bbdb-search-simple' bug, it should work fine otherwise.

> Well like I said, since a recent update, it's almost having the
> opposite effect as what I want with many messages from people in .bbdb
> going into the spam group.  I'm more than happy to try to help debug
> this, but I don't know where to begin.

Found it.

The recent change to spam.el does this:

              (if (fboundp 'bbdb-search)
                  (bbdb-search (bbdb-records) who) ;; v3
                (bbdb-search-simple nil who)) ;; v2

So it's assuming that if bbdb 2.* is in use, (fboundp 'bbdb-search) should return nil.  C-h f bbdb-search gives this:

   bbdb-search is a Lisp macro in `bbdb-com.el'.

   (bbdb-search records &optional name company net notes phone)
   [...]

I don't know if a macro is supposed to cause fboundp to return t or if I've somehow completely screwed up my emacs (23.1.1), or if there's some difference in bbdb 2.36 (sourceforge CVS) from what you expected to find,  but the above explains why bbdb look ups are not working - the search is not set up right.  bbdb-search-simple is a part of my bbdb, so for now, my trivial fix is:

(if (fboundp 'bbdb-search-simple)
    (bbdb-search-simple nil who) ;; v2
  (bbdb-search (bbdb-records) who)) ;; v3

Obviously I have no clue if that would continue to work as desired with bbdb v3, though.

-- 
Dave Goldberg
david.goldberg6@verizon.net