Gnus development mailing list
 help / color / mirror / Atom feed
From: kai.grossjohann@uni-duisburg.de (Kai Großjohann)
Subject: Re: gnus-agent typo?
Date: Wed, 23 Oct 2002 17:40:44 +0200	[thread overview]
Message-ID: <84of9l6u4j.fsf@crybaby.uni-duisburg.de> (raw)
In-Reply-To: <m3u1jdfafp.fsf@multivac.cwru.edu>

prj@po.cwru.edu (Paul Jarc) writes:

> You guessed that the original logic was buggy, and I guess the same,
> because it seems odd to treat seen and recent articles similarly.
> (Could someone who knows what that code is really supposed to do
> comment here?)  We would expect *un*seen and recent articles to be
> treated similarly, since they're semantically similar - but since
> they're implemented differently (recent is a normal mark; unseen is
> the lack of the seen mark), the code should look different than it
> does now.  So to fix the apparent bug, but otherwise produce the same
> range, we should take the initial list of article and add (seen -
> recent).  (This is different from ((initial + seen) - recent).)

The original code is supposed to add ticked and dormant messages, I
think.  And messages with other marks.  Except for the unseen and the
recent mark.

I think adding (seen - recent) does not achieve the objective of
abstaining from adding unseen articles.

What the code does is to go through the list of ticked articles and
add them.  Then it goes through the list of dormant articles and adds
them.

But it should not go through the list of unseen articles and add
them.  So it should also not go through the list of seen articles and
remove them.

See?

The original logic was correct after all, even if it is
counter-intuitive.

kai
-- 
~/.signature is: umop ap!sdn    (Frank Nobis)



  reply	other threads:[~2002-10-23 15:40 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-10-18 18:05 Kai Großjohann
2002-10-21 21:23 ` Paul Jarc
2002-10-22  8:37   ` Kai Großjohann
2002-10-22 18:02     ` Paul Jarc
2002-10-23  8:07       ` Kai Großjohann
2002-10-23 15:20         ` Paul Jarc
2002-10-23 15:40           ` Kai Großjohann [this message]
2002-10-23 15:58             ` Paul Jarc
2002-10-24  7:08               ` Kai Großjohann
2002-10-24 10:26                 ` Simon Josefsson
2002-10-24 10:35                   ` Kai Großjohann
2002-10-24 15:24                     ` Simon Josefsson
2002-10-24 16:58                       ` Kai Großjohann
2002-10-24 19:20                       ` Kai Großjohann
2002-10-24 23:30                         ` Simon Josefsson
2002-10-25  8:51                           ` Kai Großjohann
2002-10-25 10:35                             ` Simon Josefsson
2002-10-25 10:48                               ` Kai Großjohann
2002-10-26 16:56                       ` Clemens Fischer
2002-10-24 15:12                 ` Paul Jarc
2002-10-24 17:03                   ` Kai Großjohann
2002-10-24 17:34                     ` Paul Jarc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=84of9l6u4j.fsf@crybaby.uni-duisburg.de \
    --to=kai.grossjohann@uni-duisburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).