Re: Agent gone mad?

[Kai.Grossjohann@CS.Uni-Dortmund.DE (Kai Großjohann)]

Henrik Enberg <henrik@enberg.org> writes:

> Yes, because while it's fast, it also tries to download every article
> my server knows about.

Whee.  Hm.  This does not happen for me.  Otherwise things would be
even slower still.

>> Okay.  What's in the 100 megs that it is still downloading?  Is it
>> headers or articles or both?  I might need to meditate a lot more
>> about that code...
>
> It is both headers and articles.  Even those already downloaded.  It
> seems to just throw away what it downloads.

Really really strange.  How could that happen?  Can you trace the
code (with edebug?) to see what happens?

>> Btw, I've now reinstated another change of mine which abstains from
>> fetching already-fetched messages.  Maybe that helps some more.
>
> There are some changes in the behaviour.  With
> `gnus-agent-consider-all-articles' set to nil, it still does what I
> described above.  If I set it to t, Gnus just locks up until I hit C-g.
>
> I've been staring at the code for quite some time, but I don't
> understand why it doesn't work.  It is clearly conditioned on
> gnus-agent-consider-all-articles.  It really _ought_ to work.

Well, the code that's conditioned on gnus-agent-consider-all-articles
only influences the header fetching.  Hm.

There is one spot which I changed:

    ;; Remove known articles.
    (when (gnus-agent-load-alist group)
      ;; Remove articles marked as downloaded.
      (setq articles
	    (gnus-sorted-difference
	     articles
	     (delq nil
		   (mapcar (lambda (x) (when (cdr x) (car x)))
			   gnus-agent-article-alist))))
      (let ((low (1+ (caar (last gnus-agent-article-alist))))
	    (high (cdr (gnus-active group))))
	;; I suspect a deeper problem here and I suspect that low
	;; should never be greater than high.  But for the time being
	;; we just work around the problem and abstain from frobbing
	;; the article list in that case.  If anyone knows how to
	;; properly deal with it, please holler.  -- kai
	(when (<= low high)
	  (setq articles (gnus-list-range-intersection
			  articles (list (cons low high)))))))

The last `when' was not there originally.  For me, low was greater
than high and therefore gnus-list-range-intersection returned nil.

But maybe for you low is also greater than high but
gnus-list-range-intersection does not return nil?

How about you try to remove that (<= low high) condition and see what
happens?

kai
-- 
~/.signature is: umop ap!sdn    (Frank Nobis)