[patch][trivial] gnus-audio.el

[patch][trivial] gnus-audio.el

[Jhair Tocancipa Triana]

Hi,

Changes described in the proposed Changelog entry.

Thanks and regards,

-- 
--Jhair

Public Key fingerprint:
81FF 3ADF BF6B CECB C593  4018 27AE D7D2 BAA6 00D0


2003-01-13  Jhair Tocancipa Triana <jhair_tocancipa@@gmx.net>

	* gnus-audio.el (gnus-audio-au-player, gnus-audio-wav-player): Use
	  /usr/bin/play as default player. 
	  (gnus-audio-play): Added ARG-DESCRIPTOR to prompt for a file to play.

Index: gnus-audio.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/gnus-audio.el,v
retrieving revision 6.1
diff -u -r6.1 gnus-audio.el
--- gnus-audio.el	2000/12/19 22:18:39	6.1
+++ gnus-audio.el	2003/01/13 23:31:32
@@ -47,12 +47,12 @@
   :type '(choice directory (const nil))
   :group 'gnus-audio)
 
-(defcustom gnus-audio-au-player "/usr/bin/showaudio"
+(defcustom gnus-audio-au-player "/usr/bin/play"
   "Executable program for playing sun AU format sound files."
   :group 'gnus-audio
   :type 'string)
 
-(defcustom gnus-audio-wav-player "/usr/local/bin/play"
+(defcustom gnus-audio-wav-player "/usr/bin/play"
   "Executable program for playing WAV files."
   :group 'gnus-audio
   :type 'string)
@@ -93,7 +93,7 @@
 ;;;###autoload
 (defun gnus-audio-play (file)
   "Play a sound FILE through the speaker."
-  (interactive)
+  (interactive "fSound file name: ")
   (let ((sound-file (if (file-exists-p file)
 			file
 		      (expand-file-name file gnus-audio-directory))))

Re: [patch][trivial] gnus-audio.el

[Kai Großjohann]

Jhair Tocancipa Triana <jhair_tocancipa@gmx.net> writes:

> -(defcustom gnus-audio-wav-player "/usr/local/bin/play"
> +(defcustom gnus-audio-wav-player "/usr/bin/play"

IMHO, it would be better to use executable-find to find this
executable.

Why is play better than showaudio in the other case?
-- 
Ambibibentists unite!

Re: [patch][trivial] gnus-audio.el

[Lars Magne Ingebrigtsen]

Jhair Tocancipa Triana <jhair_tocancipa@gmx.net> writes:

> 	* gnus-audio.el (gnus-audio-au-player, gnus-audio-wav-player): Use
> 	  /usr/bin/play as default player. 
> 	  (gnus-audio-play): Added ARG-DESCRIPTOR to prompt for a file to play.

Thanks for the patch; I've applied it to Oort Gnus v0.13 (i. e., CVS).

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen

Re: [patch][trivial] gnus-audio.el

[Lars Magne Ingebrigtsen]

kai.grossjohann@uni-duisburg.de (Kai Großjohann) writes:

> IMHO, it would be better to use executable-find to find this
> executable.

I've now done that.

> Why is play better than showaudio in the other case?

Uhm...  good question.  :-)

-- 
(domestic pets only, the antidote for overdose, milk.)
   larsi@gnus.org * Lars Magne Ingebrigtsen