Re: format called for effect

[kai.grossjohann@uni-duisburg.de (Kai Großjohann)]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> kai.grossjohann@uni-duisburg.de (Kai Großjohann) writes:
>
>> When byte-compiling Gnus, I see the message from subject.  It comes
>> from gnus-msg.el, line 1497 or so, if I'm not mistaken. 
>
> This code:
>
> 	  (condition-case ()
> 	      (pp `(setq ,(car olist)
> 			 ,(if (or (consp (setq sym (symbol-value (car olist))))
> 				  (and (symbolp sym)
> 				       (not (or (eq sym nil)
> 						(eq sym t)))))
> 			      (list 'quote (symbol-value (car olist)))
> 			    (symbol-value (car olist))))
> 		  (current-buffer))
> 	    (error
> 	     (format "(setq %s 'whatever)\n" (car olist))))
>
> First of all -- I have no idea why that `condition-case' is the way
> it is.  I didn't know that `format' had any effect?  Does it?  And if
> it doesn't, why is that code that way?  If nobody has an explanation,
> I'll just remove the `format'.

Thinking some more about it, maybe what was intended was to try to
insert one setq statement, and to insert another setq statement in
the case of an error.

So maybe the condition-case should be around the if and return
`whatever' in case of error?
-- 
Ambibibentists unite!