Gnus development mailing list
 help / color / mirror / Atom feed
From: David Kastrup <dak@gnu.org>
To: ding@gnus.org, emacs-devel@gnu.org, ratinox@peorth.gweep.net
Subject: Is this patch of gnus/pop3.el reasonable?
Date: Mon, 01 Oct 2007 00:38:05 +0200	[thread overview]
Message-ID: <85ir5r2302.fsf@lola.goethe.zz> (raw)

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]


I am currently cleaning through unchecked changes in my Emacs tree.  I
found that I have made the following change, presumably in order to
stop pop3 fetching from hanging in some cases with a possibly patchy
pop3 server.  Could also be related to coding system translation or
something.

Now the question is whether this is a bad idea to check into upstream.
I can't see that it will affect operation where the server is correct,
and it might avoid hangs where it isn't.

What do you think?


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 431 bytes --]

--- pop3.el	01 Aug 2007 00:14:10 +0200	1.38
+++ pop3.el	11 Aug 2007 08:56:13 +0200	
@@ -246,7 +246,7 @@
       (set-buffer (process-buffer process))
       (goto-char pop3-read-point)
       (while (and (memq (process-status process) '(open run))
-		  (not (search-forward "\r\n" nil t)))
+		  (not (search-forward "\n" nil t)))
 	(pop3-accept-process-output process)
 	(goto-char pop3-read-point))
       (setq match-end (point))

[-- Attachment #3: Type: text/plain, Size: 51 bytes --]


-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

             reply	other threads:[~2007-09-30 22:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-30 22:38 David Kastrup [this message]
2007-09-30 23:01 ` Leo
2007-10-01  0:06 ` Stainless Steel Rat
2007-10-01  6:32 ` Zhang Wei
2007-10-01 18:16   ` Stainless Steel Rat
2007-10-01 17:40 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85ir5r2302.fsf@lola.goethe.zz \
    --to=dak@gnu.org \
    --cc=ding@gnus.org \
    --cc=emacs-devel@gnu.org \
    --cc=ratinox@peorth.gweep.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).