From: Ted Zlatanov <tzz@lifelogs.com>
To: Joao Cachopo <joao@cachopo.org>
Cc: ding@gnus.org
Subject: Re: Problem with gnus-registry-grep-in-list
Date: Mon, 05 May 2008 16:42:24 -0500 [thread overview]
Message-ID: <864p9c2zsv.fsf@lifelogs.com> (raw)
In-Reply-To: <m21w4gr3y7.fsf@cachopo.org> (Joao Cachopo's message of "Mon, 05 May 2008 19:38:56 +0100")
On Mon, 05 May 2008 19:38:56 +0100 Joao Cachopo <joao@cachopo.org> wrote:
JC> The string-match function is called with the regexp in the second
JC> argument, rather than the first.
Fixed, please test. I used catch/throw now instead of mapcar, it should
be more efficient.
JC> Actually, according to the CVS logs, this was a deliberate change made
JC> in revision 7.37:
JC> date: 2007/09/12 09:16:25; author: tzz; state: Exp; lines: +3 -3
JC> (gnus-registry-unfollowed-groups): Add INBOX to the
JC> list of groups not followed by default. Fix type to be regexp.
JC> (gnus-registry-grep-in-list): Fix inverted parameters to string-match.
My mistake, sorry.
JC> As the gnus-registry-grep-in-list function is used in one more place
JC> (the function gnus-registry-find-keywords), I'm not sure that swapping
JC> the arguments of the string-match again will not break this other
JC> functionality.
I doubt anyone uses gnus-registry-find-keywords, but I fixed it anyhow
to just use the member function instead of the regular expression
matching.
Ted
next prev parent reply other threads:[~2008-05-05 21:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-05 18:38 Joao Cachopo
2008-05-05 21:42 ` Ted Zlatanov [this message]
2008-05-06 8:19 ` Joao Cachopo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=864p9c2zsv.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=ding@gnus.org \
--cc=joao@cachopo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).