From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/20038 Path: main.gmane.org!not-for-mail From: wmperry@aventail.com (William M. Perry) Newsgroups: gmane.emacs.gnus.general Subject: Re: text/html clickable links fail in p0.63+w3-4.0pre31 Date: 28 Dec 1998 16:43:29 -0500 Sender: owner-ding@hpc.uh.edu Message-ID: <8667awuem6.fsf@kramer.bp.aventail.com> References: Reply-To: wmperry@aventail.com NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 X-Trace: main.gmane.org 1035158347 15136 80.91.224.250 (20 Oct 2002 23:59:07 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 20 Oct 2002 23:59:07 +0000 (UTC) Return-Path: Original-Received: from karazm.math.uh.edu (karazm.math.uh.edu [129.7.128.1]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id QAA22385 for ; Mon, 28 Dec 1998 16:44:10 -0500 (EST) Original-Received: from sina.hpc.uh.edu (lists@Sina.HPC.UH.EDU [129.7.3.5]) by karazm.math.uh.edu (8.9.1/8.9.1) with ESMTP id PAB06375; Mon, 28 Dec 1998 15:43:49 -0600 (CST) Original-Received: by sina.hpc.uh.edu (TLB v0.09a (1.20 tibbs 1996/10/09 22:03:07)); Mon, 28 Dec 1998 15:43:50 -0600 (CST) Original-Received: from sclp3.sclp.com (root@sclp3.sclp.com [204.252.123.139]) by sina.hpc.uh.edu (8.7.3/8.7.3) with ESMTP id PAA11706 for ; Mon, 28 Dec 1998 15:43:40 -0600 (CST) Original-Received: from slow.bp.aventail.com (usrpri1-6.kiva.net [208.143.10.195]) by sclp3.sclp.com (8.8.5/8.8.5) with ESMTP id QAA22371 for ; Mon, 28 Dec 1998 16:43:30 -0500 (EST) Original-Received: from kramer.bp.aventail.com (kramer.bp.aventail.com [192.168.2.2]) by slow.bp.aventail.com (8.8.5/8.8.5) with ESMTP id QAA26290 for ; Mon, 28 Dec 1998 16:42:12 -0800 Original-Received: (from wmperry@localhost) by kramer.bp.aventail.com (8.8.5/8.8.5) id QAA06938; Mon, 28 Dec 1998 16:43:29 -0500 Original-To: ding@gnus.org X-Face: O~Rn;(l][/-o1sALg4A@xpE:9-"'IR[%;,,!m7 writes: > Karl Kleinpaste writes: > > > A forwarded text/html article in a local newsgroup contains numerous > > 's. Merely passing the mouse over these links induces this > > stack trace: > > > > Signaling: (args-out-of-range # # #) > > [...] > > > (I'm experimenting with XEmacs 21.2-b4, so if that's part of the > > problem, I suppose this should be ignored...) > > I get the same thing (XEmacs 21.2; newest w3). The backtrace looks like > it's trying to do a buffer-substring on the summary buffer with two marks > from the article buffer. Perhaps w3 looked at the selected window > instead of the current buffer when creating the callback function > thingies? (Because the summary buffer is normally the selected window > when rendering the article buffer.) The widget-echo stuff was not being careful about where it looked for the text of the link for echoing purposes. Try this patch. -Bill P. Index: w3-display.el =================================================================== RCS file: /gd/gnu/cvsroot/w3/lisp/w3-display.el,v retrieving revision 1.7 diff -c -w -c -w -r1.7 w3-display.el *** w3-display.el 1998/12/28 16:38:40 1.7 --- w3-display.el 1998/12/28 21:42:37 *************** *** 496,502 **** --- 496,512 ---- (setq w3-cookie-cache (cons (cons href fname) w3-cookie-cache)))) (cookie fname st nd)))) + (defun w3-widget-buffer (widget) + (let ((overlay (or (widget-get widget :button-overlay) + (widget-get widget :field-overlay))) + (extent (or (widget-get widget :button-extent) + (widget-get widget :field-extent)))) + (or (and overlay (overlay-buffer overlay)) + (and extent (extent-buffer extent))))) + (defun w3-widget-echo (widget &rest ignore) + (save-excursion + (set-buffer (or (w3-widget-buffer widget) (current-buffer))) (let* ((url (widget-get widget :href)) (name (widget-get widget :name)) (text (buffer-substring-no-properties (widget-get widget :from) *************** *** 516,522 **** (stringp (symbol-value (car check))) (> (length (symbol-value (car check))) 0) (throw 'exit (symbol-value (car check)))) ! (pop check))))) (defun w3-follow-hyperlink (widget &rest ignore) (let* ((target (or (widget-get widget :target) w3-base-target)) --- 526,532 ---- (stringp (symbol-value (car check))) (> (length (symbol-value (car check))) 0) (throw 'exit (symbol-value (car check)))) ! (pop check)))))) (defun w3-follow-hyperlink (widget &rest ignore) (let* ((target (or (widget-get widget :target) w3-base-target))