From: Ted Zlatanov <tzz@lifelogs.com>
To: ding@gnus.org
Subject: Re: FIXMEs in imap.el and nnimap.el
Date: Wed, 07 Jan 2009 13:25:26 -0600 [thread overview]
Message-ID: <86d4eyvryx.fsf@lifelogs.com> (raw)
In-Reply-To: <878wpt48qj.fsf@marauder.physik.uni-ulm.de>
On Fri, 02 Jan 2009 23:57:08 +0100 Reiner Steib <reinersteib+gmane@imap.cc> wrote:
>> (defun imap-message-copyuid-1 (mailbox)
>> + (imap-message-copyuid-or-appenduid-1 mailbox t))
>> +
>> + (defun imap-message-appenduid-1 (mailbox)
>> + (imap-message-copyuid-or-appenduid-1 mailbox nil))
>> +
>> + (defun imap-message-copyuid-or-appenduid-1 (mailbox copy)
>> (if (imap-capability 'UIDPLUS)
>> ! (if copy
RS> I'd rather use
RS> (defun imap-message-copyuid-1 (mailbox &optional append)
RS> or
RS> (defun imap-message-appenduid-1 (mailbox &optional copy)
RS> and adjust the callers.
Why? The two functions are clearly mapped to separate IMAP concepts, so
merging them and requiring all the callers to adjust is unnecessary
pain.
The other issue (cons cell vs. list for "*" "*:*") I'll leave to Dave.
Ted
next prev parent reply other threads:[~2009-01-07 19:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87iqphil5p.fsf@liv.ac.uk>
2008-12-22 22:38 ` imap.el workaround for Exchange 2007 Reiner Steib
2008-12-23 15:41 ` Dave Love
2009-01-01 18:34 ` Reiner Steib
2009-01-02 22:20 ` Ted Zlatanov
2009-01-02 22:38 ` Reiner Steib
2009-01-09 12:00 ` Simon Josefsson
2009-01-01 18:55 ` FIXMEs in imap.el and nnimap.el (was: imap.el workaround for Exchange 2007) Reiner Steib
2009-01-02 22:19 ` FIXMEs in imap.el and nnimap.el Ted Zlatanov
2009-01-02 22:57 ` Reiner Steib
2009-01-04 23:10 ` Dave Love
2009-01-07 21:07 ` Dave Love
2009-01-08 20:42 ` Reiner Steib
2009-01-07 19:25 ` Ted Zlatanov [this message]
2009-01-08 21:04 ` Reiner Steib
2009-01-13 10:40 ` Dave Love
2009-01-13 17:00 ` IMAP and Exchange 2007 - imap-fetch-safe (was: FIXMEs in imap.el and nnimap.el) Reiner Steib
2009-01-13 17:20 ` IMAP and Exchange 2007 - imap-fetch-safe Simon Josefsson
2009-01-17 20:58 ` Dave Love
2009-01-28 1:18 ` Dave Love
2009-01-31 15:27 ` Reiner Steib
2009-02-01 15:43 ` Bjorn Solberg
2009-02-02 14:54 ` Dave Goldberg
2009-02-02 19:19 ` Reiner Steib
2009-02-03 16:21 ` Stephen J. Turnbull
2009-02-08 18:00 ` Dave Love
2009-02-08 18:38 ` Dave Goldberg
2009-02-02 19:15 ` Reiner Steib
2009-01-13 18:28 ` Bjorn Solberg
2009-01-13 20:18 ` Bjorn Solberg
2009-01-17 20:59 ` Dave Love
2009-01-04 20:08 ` FIXMEs in imap.el and nnimap.el Dave Love
2009-01-05 16:13 ` Dave Love
2009-01-05 20:35 ` Conventions (was: FIXMEs in imap.el and nnimap.el) Reiner Steib
2009-01-06 11:33 ` Conventions Tassilo Horn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86d4eyvryx.fsf@lifelogs.com \
--to=tzz@lifelogs.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).