From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/68101 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: FIXMEs in imap.el and nnimap.el Date: Wed, 07 Jan 2009 13:25:26 -0600 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <86d4eyvryx.fsf@lifelogs.com> References: <87iqphil5p.fsf@liv.ac.uk> <87ocz3n8d4.fsf@marauder.physik.uni-ulm.de> <87iqpa99wy.fsf@liv.ac.uk> <87wsde7t5j.fsf_-_@marauder.physik.uni-ulm.de> <86mye95p27.fsf@lifelogs.com> <878wpt48qj.fsf@marauder.physik.uni-ulm.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1231356387 13848 80.91.229.12 (7 Jan 2009 19:26:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 7 Jan 2009 19:26:27 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M16546@lists.math.uh.edu Wed Jan 07 20:27:38 2009 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1LKe3k-0008Hp-9R for ding-account@gmane.org; Wed, 07 Jan 2009 20:27:20 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1LKe1Z-0002Tt-4Y; Wed, 07 Jan 2009 13:25:05 -0600 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1LKe1W-0002Td-Er for ding@lists.math.uh.edu; Wed, 07 Jan 2009 13:25:02 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1LKe1T-0005Jb-Oj for ding@lists.math.uh.edu; Wed, 07 Jan 2009 13:25:02 -0600 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1LKe1k-00049n-00 for ; Wed, 07 Jan 2009 20:25:16 +0100 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1LKe1Q-0008K4-H5 for ding@gnus.org; Wed, 07 Jan 2009 19:24:56 +0000 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 07 Jan 2009 19:24:56 +0000 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 07 Jan 2009 19:24:56 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 25 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:PABewWwK+VCnCcq5lPhgX6+7AQ8= X-Spam-Score: -1.5 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:68101 Archived-At: On Fri, 02 Jan 2009 23:57:08 +0100 Reiner Steib wrote: >> (defun imap-message-copyuid-1 (mailbox) >> + (imap-message-copyuid-or-appenduid-1 mailbox t)) >> + >> + (defun imap-message-appenduid-1 (mailbox) >> + (imap-message-copyuid-or-appenduid-1 mailbox nil)) >> + >> + (defun imap-message-copyuid-or-appenduid-1 (mailbox copy) >> (if (imap-capability 'UIDPLUS) >> ! (if copy RS> I'd rather use RS> (defun imap-message-copyuid-1 (mailbox &optional append) RS> or RS> (defun imap-message-appenduid-1 (mailbox &optional copy) RS> and adjust the callers. Why? The two functions are clearly mapped to separate IMAP concepts, so merging them and requiring all the callers to adjust is unnecessary pain. The other issue (cons cell vs. list for "*" "*:*") I'll leave to Dave. Ted