Gnus development mailing list
 help / color / mirror / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: Andreas Schwab <schwab@suse.de>
Cc: ding@gnus.org
Subject: Re: Error in `mail-source-bind' when fetching mail
Date: Mon, 28 Apr 2008 11:53:32 -0500	[thread overview]
Message-ID: <86d4o9udir.fsf@lifelogs.com> (raw)
In-Reply-To: <m27iei2s02.fsf@igel.home> (Andreas Schwab's message of "Mon, 28 Apr 2008 12:28:13 +0200")

On Mon, 28 Apr 2008 12:28:13 +0200 Andreas Schwab <schwab@suse.de> wrote: 

AS> Ted Zlatanov <tzz@lifelogs.com> writes:
>> I made a fix that should do the right thing; it may be
>> better to do it with macro facilities but I wanted to get the fix out
>> ASAP and I did it the simplest way possible (with boundp, symbol-value,
>> and unintern).

AS> The use of unintern is broken.  You want makunbound instead.

Thanks.  I moved the code out of the macro altogether, I didn't think it
was clear anyhow, and it was much harder to debug.  The restructured
version is much cleaner IMO, and only calls the auth-source functions if
the keywords actually show up.  Please let me know if you find other
problems or issues.

As an aside, I kept making fixes and re-evaluating the defmacro but it
wouldn't take effect.  I guess I don't know defmacro well enough, but I
didn't expect that from the documentation (I usually only use the
backquote macros).  It was a bit annoying until I finally realized what
was happening.

Ted



  reply	other threads:[~2008-04-28 16:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <874p9pqhnj.fsf@ID-24456.user.uni-berlin.de>
2008-04-26 12:45 ` Ted Zlatanov
2008-04-26 16:43   ` Christoph Conrad
2008-04-28 10:11   ` Andreas Schwab
2008-04-28 10:28   ` Andreas Schwab
2008-04-28 16:53     ` Ted Zlatanov [this message]
2008-04-29  3:26       ` Cezar Halmagean
2008-04-30 14:30         ` Ted Zlatanov
2009-02-20 12:11 ` Reiner Steib

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86d4o9udir.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=ding@gnus.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).