From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67754 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general,gmane.emacs.devel Subject: Re: smtpmail and starttls improvement when starttls program is missing Date: Tue, 04 Nov 2008 10:50:36 -0600 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <86ej1rv3j7.fsf@lifelogs.com> References: <86wsfrayh9.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1225820426 32154 80.91.229.12 (4 Nov 2008 17:40:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 4 Nov 2008 17:40:26 +0000 (UTC) Cc: emacs-devel@gnu.org To: ding@gnus.org Original-X-From: ding-owner+M16205@lists.math.uh.edu Tue Nov 04 18:41:28 2008 connect(): Connection refused Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1KxPtl-0004XU-SE for ding-account@gmane.org; Tue, 04 Nov 2008 18:41:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1KxPrj-000615-Si; Tue, 04 Nov 2008 11:38:55 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1KxPri-00060s-Kd for ding@lists.math.uh.edu; Tue, 04 Nov 2008 11:38:54 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1KxPrg-0002mF-Ed for ding@lists.math.uh.edu; Tue, 04 Nov 2008 11:38:54 -0600 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1KxPGG-0008Jn-00 for ; Tue, 04 Nov 2008 18:00:12 +0100 Original-Received: from root by ciao.gmane.org with local (Exim 4.43) id 1KxPG6-0000js-Ut for ding@gnus.org; Tue, 04 Nov 2008 17:00:02 +0000 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 04 Nov 2008 17:00:02 +0000 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 04 Nov 2008 17:00:02 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 40 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/23.0.60 (gnu/linux) Cancel-Lock: sha1:B7GmHajBvixxf/y2OyVvOdDJfZg= X-Spam-Score: -1.5 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67754 gmane.emacs.devel:105348 Archived-At: On Tue, 04 Nov 2008 09:53:17 +0900 Katsumi Yamaoka wrote: KY> I think `with-no-warnings' and `(require 'starttls)' are unnecessary. KY> For `with-no-warnings', it binds `byte-compile-warnings' to nil KY> when compiling. It is for making the byte compiler silent on any KY> form, however there seems nothing to be warned when compiling. KY> In addition, `with-no-warnings' is not available in Emacs 21 and KY> XEmacs that Gnus supports, so the warning like the following is KY> issued when compiling Gnus: KY> While compiling the end of the data in file gnus/lisp/starttls.el: KY> ** The function `with-no-warnings' is not known to be defined. KY> It is not serious since the function will not be used with those KY> versions of Emacsen, though. OK. This was in the original code in smtpmail.el, I just moved it out to starttls.el where it was more appropriate. KY> For `(require 'starttls)', the reason I say it is unnecessary is KY> that the function is defined in starttls.el that provides the KY> `starttls' feature. ;-) Therefore the function can be rewritten KY> like the following, isn't it? KY> (defun starttls-any-program-available () KY> (let ((program (if starttls-use-gnutls KY> starttls-gnutls-program KY> starttls-program))) KY> (condition-case () KY> (progn KY> (call-process program) KY> program) KY> (error (progn KY> (message "No STARTTLS program was available (tried '%s')" KY> program) KY> nil))))) Yes, that's better, thanks. I wasn't paying attention when I copied the code. Comitted. Ted