Gnus development mailing list
 help / color / mirror / Atom feed
From: Andrew Cohen <cohen@bu.edu>
To: ding@gnus.org
Subject: Re: Testers wanted: New gnus backend nnselect
Date: Tue, 25 Apr 2017 08:09:52 +0800	[thread overview]
Message-ID: <871sshcppr.fsf@hanan> (raw)
In-Reply-To: <87r30h5xzt.fsf@ericabrahamsen.net>

>>>>> "Eric" == Eric Abrahamsen <eric@ericabrahamsen.net> writes:

    Eric> Andrew Cohen <cohen@bu.edu> writes:
    >> TLDR: Please test the new feature found on the git repository at
    >> feature/gnus-select.

    Eric> Very cool! Later this week I'll make another copy of the
    Eric> search-language branch that's rebased onto this one.

    Eric> [...]


[...]

    Eric> Once this has landed, I hope we can rename nnir.el to
    Eric> gnus-search.el, and drop the "nnir" term altogether.


Yes, that's what I meant when I said there was a lot of renaming to do:) 

[...]


    Eric> I've started on a gnus-search-thread method for the search
    Eric> engines -- in fact, the majority of them can already handle
    Eric> searching by thread.  Ideally `nnselect-request-thread' could
    Eric> then become engine-agnostic, and only punt if the engine in
    Eric> question doesn't implement the `gnus-search-thread' method.

Great! But there is one quirk to keep in mind. If you start in a
"normal" group (like one with an imap backend) you can't (easily) insert
articles from other groups into the same summary buffer. If you look at
nnimap-request-thread you will notice that if
gnus-refer-thread-use-search is nil then only the current group is
probed for thread articles. But if its non-nil then it defers to
nnselect-search-thread which creates a NEW nnselect ephemeral buffer to
allow the results to cross groups. You can probably implement this in 
new nnfoo-request-thread methods for all the backends.

The function nnselect-request-thread is called only when referring a
thread from an nnselect group. The only way it is engine specific right
now is in the construction of the search query string
(nnimap-make-thread-query). So you could provide a function
nnir-make-thread-query (or better yet encapsulate the whole nnir related
stuff in nnselect-request-thread into a function like nnir-refer-thread)
and this would make the function fully universal (and keep all the
search-related junk in nnir where it belongs)

Then this same function can be used in nnselect-search-thread,
easy-peasy.

Sorry, re-reading the above paragraphs I might not have been clear (but
maybe I was?) And I guess I'm suggesting the function should be called
gnus-refer-thread.


[...]

    Eric> I think that, to maximize chances of people actually testing
    Eric> this, it would be best to provide a ready-made
    Eric> `gnus-group-make-persistent-search-group' function (or call it
    Eric> whatever), and give it a keybinding. Say:

But it has a keybinding: the usual one!  "G m"
(gnus-group-make-group):)

OK, OK,  it will only take a second to make a dedicated function.
But at some point I hope people go beyond searching in the testing. 


[...]


Best,
Andy




  reply	other threads:[~2017-04-25  0:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-24  3:02 Andrew Cohen
2017-04-24 20:52 ` Eric Abrahamsen
2017-04-25  0:09   ` Andrew Cohen [this message]
2017-04-25  1:01     ` Andrew Cohen
2017-04-25 15:33     ` Eric Abrahamsen
2017-04-27 16:03 ` Harry Putnam
2017-04-27 18:24   ` Eric Abrahamsen
2017-04-28 14:53     ` Harry Putnam
2017-04-28 15:23       ` Eric Abrahamsen
2017-04-28 15:44         ` Harry Putnam
     [not found] ` <8eff03d9274e4d0fa58c85a87381706f@HE1PR01MB1898.eurprd01.prod.exchangelabs.com>
     [not found]   ` <87vapp6izc.fsf@delle7240>
2017-04-28 15:34     ` Eric Abrahamsen
2018-04-11 19:44 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871sshcppr.fsf@hanan \
    --to=cohen@bu.edu \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).