Gnus development mailing list
 help / color / mirror / Atom feed
From: Uwe Brauer <oub@mat.ucm.es>
To: ding@gnus.org
Subject: Re: registry and the gnus-summary-line-format
Date: Tue, 21 Feb 2017 18:18:38 +0000	[thread overview]
Message-ID: <871surh0g1.fsf@mat.ucm.es> (raw)
In-Reply-To: <878toztso2.fsf@ericabrahamsen.net>


   > Uwe Brauer <oub@mat.ucm.es> writes:

   > [...]


   > The error is in:

   > #+BEGIN_SRC elisp
   > (defun gnus-registry-article-marks-to-chars (headers)
   >   "Show the marks for an article by the :char property."
   >   (let* ((id (mail-header-message-id headers))
   >          (marks (when id (gnus-registry-get-id-key id 'mark))))
   >     (mapconcat (lambda (mark)
   >                  (plist-get
   >                   (cdr-safe
   >                    (assoc mark gnus-registry-marks))
   >                   :char))
   >                marks "")))
   > #+END_SRC

   > It's trying to mapconcat a bare character (116 or ?t), but mapconcat
   > requires a string or a list of characters.

   > I don't see how this ever would have worked, to be honest. Git blame
   > says the code's been like this since 2011, but supposedly mapconcat
   > started barfing on integer arguments in Emacs 21.1, in 2001. Anyhow,
   > wrapping the `plist-get' in a `char-to-string' (or just `list') will fix
   > it.

Excellent I will try this out right now. Thanks

I will then try out the registry with gnorb but this is a different
issue.

Uwe


   > I can open a bug report in a bit, if no one leaps in and fixes it.

   > Eric







  reply	other threads:[~2017-02-21 18:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-19 21:45 Uwe Brauer
2017-02-20  1:06 ` Eric Abrahamsen
2017-02-21 12:01   ` Uwe Brauer
2017-02-21 16:28     ` Eric Abrahamsen
2017-02-21 18:18       ` Uwe Brauer [this message]
2017-02-21 18:23       ` Uwe Brauer
2017-02-21 18:32         ` Eric Abrahamsen
2017-02-21 20:08           ` Uwe Brauer
2017-02-22  0:34             ` Eric Abrahamsen
2017-02-22  9:25               ` Uwe Brauer
2017-02-22 16:59                 ` Eric Abrahamsen
2017-02-22 17:38                   ` Uwe Brauer
2017-02-21 21:49           ` Uwe Brauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871surh0g1.fsf@mat.ucm.es \
    --to=oub@mat.ucm.es \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).