* deleting articles in nnimap
@ 2011-08-20 19:52 Simon Josefsson
2011-08-21 3:36 ` Lars Magne Ingebrigtsen
0 siblings, 1 reply; 3+ messages in thread
From: Simon Josefsson @ 2011-08-20 19:52 UTC (permalink / raw)
To: ding
Gnus nicely saves a copy of each nnimap article I read in my
~/News/agent/nnimap/foo/INBOX.bar/ folder, however removing a message
only seems to delete it on the server. Shouldn't it remove the cached
article locally, too? I delete with B DEL yes RET.
Further, the messages shown when deleting a message are:
Expiring articles in nnimap+yxa:INBOX.2011
gnus-agent-expire: Loading overview... Done
gnus-agent-expire: Sorting entries... Done
gnus-agent-expire: Merging entries... Done
gnus-agent-expire: nnimap+yxa:INBOX.2011:11700: NOV entry removed
Expiry recovered 1 NOV entries, deleted 0 files, and freed 751.000000 B.
The "deleted 0 files" indicates it CAN delete files, right? So maybe
there is a bug rather than missing functionality.
Also, the amount of precision in the format string output seems a bit
excessive. How about simple patch below?
/Simon
2011-08-20 Simon Josefsson <simon@josefsson.org>
* gnus-agent.el (gnus-agent-expire-done-message): Use %.f as format
specified to reduce precision.
diff --git a/lisp/gnus-agent.el b/lisp/gnus-agent.el
index 424c55c..2622211 100644
--- a/lisp/gnus-agent.el
+++ b/lisp/gnus-agent.el
@@ -3560,7 +3560,7 @@ articles in every agentized group? "))
units (cdr units)))
(format "Expiry recovered %d NOV entries, deleted %d files,\
- and freed %f %s."
+ and freed %.f %s."
(nth 0 stats)
(nth 1 stats)
size (car units)))
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: deleting articles in nnimap
2011-08-20 19:52 deleting articles in nnimap Simon Josefsson
@ 2011-08-21 3:36 ` Lars Magne Ingebrigtsen
2011-08-21 12:32 ` Steinar Bang
0 siblings, 1 reply; 3+ messages in thread
From: Lars Magne Ingebrigtsen @ 2011-08-21 3:36 UTC (permalink / raw)
To: ding
Simon Josefsson <simon@josefsson.org> writes:
> Gnus nicely saves a copy of each nnimap article I read in my
> ~/News/agent/nnimap/foo/INBOX.bar/ folder, however removing a message
> only seems to delete it on the server. Shouldn't it remove the cached
> article locally, too? I delete with B DEL yes RET.
Yes, `B DEL' should definitely delete the file from the agent cache,
too. I think. However, I'm not really familiar with that code...
hm...
> Also, the amount of precision in the format string output seems a bit
> excessive. How about simple patch below?
Thanks; applied.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: deleting articles in nnimap
2011-08-21 3:36 ` Lars Magne Ingebrigtsen
@ 2011-08-21 12:32 ` Steinar Bang
0 siblings, 0 replies; 3+ messages in thread
From: Steinar Bang @ 2011-08-21 12:32 UTC (permalink / raw)
To: ding
>>>>> Lars Magne Ingebrigtsen <larsi@gnus.org>:
> Yes, `B DEL' should definitely delete the file from the agent cache,
> too. I think.
It definitely should.
> However, I'm not really familiar with that code... hm...
It seems that nobody are familiar with that code. It has many bugs,
especially with nnimap, and debugging into it is... obscure.
Re-think, re-design, and re-implement? Something to put on the list
for the cloudy one?
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-08-21 12:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-20 19:52 deleting articles in nnimap Simon Josefsson
2011-08-21 3:36 ` Lars Magne Ingebrigtsen
2011-08-21 12:32 ` Steinar Bang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).