From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/79008 Path: news.gmane.org!not-for-mail From: Ted Zlatanov Newsgroups: gmane.emacs.gnus.general Subject: Re: spam-stat warning Date: Wed, 01 Jun 2011 08:09:31 -0500 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Message-ID: <871uzdwvec.fsf@lifelogs.com> References: Reply-To: ding@gnus.org NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1306933835 21580 80.91.229.12 (1 Jun 2011 13:10:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 1 Jun 2011 13:10:35 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M27308@lists.math.uh.edu Wed Jun 01 15:10:31 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QRlBs-0005ha-Sc for ding-account@gmane.org; Wed, 01 Jun 2011 15:10:29 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1QRlBH-000420-O0; Wed, 01 Jun 2011 08:09:51 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1QRlBG-00041s-BS for ding@lists.math.uh.edu; Wed, 01 Jun 2011 08:09:50 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1QRlBB-0001AE-Es for ding@lists.math.uh.edu; Wed, 01 Jun 2011 08:09:49 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1QRlB8-00051r-Ce for ding@gnus.org; Wed, 01 Jun 2011 15:09:42 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1QRlB7-0005K5-F3 for ding@gnus.org; Wed, 01 Jun 2011 15:09:41 +0200 Original-Received: from 38.98.147.130 ([38.98.147.130]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 01 Jun 2011 15:09:41 +0200 Original-Received: from tzz by 38.98.147.130 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 01 Jun 2011 15:09:41 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: ding@gnus.org Original-Lines: 37 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 38.98.147.130 X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6;d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:5m0lk4k7ytSmzMlKbX/cKqLnNj0= X-Spam-Score: -3.7 (---) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:79008 Archived-At: On Tue, 31 May 2011 23:09:35 +0200 Lars Magne Ingebrigtsen wrote: LMI> On each Gnus startup I now get the following warning in Emacs 24: LMI> Warning: defvar ignored because spam-stat-install-hooks is let-bound LMI> And this is the reason: LMI> (eval-and-compile LMI> (when (condition-case nil LMI> (let ((spam-stat-install-hooks nil)) LMI> (require 'spam-stat)) LMI> (file-error LMI> (defalias 'spam-stat-register-ham-routine 'ignore) LMI> (defalias 'spam-stat-register-spam-routine 'ignore) LMI> nil)) LMI> And this is because: LMI> (when spam-stat-install-hooks LMI> (spam-stat-install-hooks-function)) LMI> I think that this may be a misfeature. Just `require'-ing a file should LMI> do anything but load the file, in my opinion. If you want to install LMI> stuff, then you should call the installation function explicitly. LMI> Otherwise it's just too confusing... I don't think many people are using spam-stat.el anyway, so changing this immediately is OK with me. Do you want: (defun spam-stat-install () (interactive) (when spam-stat-install-hooks (spam-stat-install-hooks-function))) or were you thinking deeper surgery? Ted