Re: faster gnus-thread-latest-date

[Dan Christensen <jdc@uwo.ca>]

[-- Attachment #1: Type: text/plain, Size: 530 bytes --]

Here's another patch that I think should be applied.  When parsing a
date, it first tries parse-time-string, and only falls back to using
timezone-make-date-arpa-standard if parse-time-string gives an error.
This is about 4 times faster in my tests with good dates, and shaves
0.6s off of opening a summary buffer with 6000 articles.  I've cc'd 
Dave Love since I believe he introduced this.  If he can confirm that
the problematic dates he encountered triggered an error in
parse-time-string, then this patch should be ok.

Dan


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: time-date.patch --]
[-- Type: text/x-diff, Size: 1653 bytes --]

Index: time-date.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/time-date.el,v
retrieving revision 7.18
diff -u -r7.18 time-date.el
--- time-date.el	9 Sep 2009 09:31:35 -0000	7.18
+++ time-date.el	11 Dec 2009 22:02:32 -0000
@@ -97,19 +97,19 @@
 (autoload 'timezone-make-date-arpa-standard "timezone")
 
 ;;;###autoload
+;; `parse-time-string' isn't sufficiently general or robust.  It fails
+;; to grok some of the formats that timezone does (e.g. dodgy
+;; post-2000 stuff from some Elms) and either fails or returns bogus
+;; values.  timezone-make-date-arpa-standard should help.
 (defun date-to-time (date)
   "Parse a string DATE that represents a date-time and return a time value."
   (condition-case ()
-      (apply 'encode-time
-	     (parse-time-string
-	      ;; `parse-time-string' isn't sufficiently general or
-	      ;; robust.  It fails to grok some of the formats that
-	      ;; timezone does (e.g. dodgy post-2000 stuff from some
-	      ;; Elms) and either fails or returns bogus values.  Lars
-	      ;; reverted this change, but that loses non-trivially
-	      ;; often for me.  -- fx
-	      (timezone-make-date-arpa-standard date)))
-    (error (error "Invalid date: %s" date))))
+      (apply 'encode-time (parse-time-string date))
+    (error (condition-case ()
+	       (apply 'encode-time 
+		      (parse-time-string
+		       (timezone-make-date-arpa-standard date)))
+	     (error (error "Invalid date: %s" date))))))
 
 ;; Bit of a mess.  Emacs has float-time since at least 21.1.
 ;; This file is synced to Gnus, and XEmacs packages may have been written