From: Stefan Wiens <s.wi@gmx.net>
Subject: In gnus-sum.el: Incorrect handling of sparse articles
Date: Sun, 14 Mar 2004 14:05:00 +0100 [thread overview]
Message-ID: <871xnvh94z.fsf@xenon.eswe.dyndns.org> (raw)
Hi,
in gnus-sum.el, function gnus-read-header:
(defun gnus-read-header (id &optional header)
"Read the headers of article ID and enter them into the Gnus system."
[...]
;; If this is a sparse article, we have to nix out its
;; previous entry in the thread hashtb.
(when (and header
(gnus-summary-article-sparse-p (mail-header-number header)))
(let* ((parent (gnus-parent-id (mail-header-references header)))
(thread (and parent (gnus-id-to-thread parent))))
(when thread
(delq (assq header thread) thread))))
^^^^
That `delq' operation trashes the thread structure in the
gnus-newsgroup-dependencies table. In contrast to the comment, it does
not remove the "previous entry" from the table, but causes the thread
to be split.
Is this (supposed) "expunging" really necessary?
If the sparse header is left in place, gnus-get-newsgroup-headers will
simply replace it.
I believe that weird code causes the long-standing problems with `^',
`A T', `A R' when gnus-build-sparse-threads is set to e. g. 'some.
I am currently testing with the offending code (cited above) commented
out, and everything seems to work fine.
Stefan
next reply other threads:[~2004-03-14 13:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-14 13:05 Stefan Wiens [this message]
2004-03-15 10:50 ` Stefan Wiens
2004-03-15 12:34 ` Katsumi Yamaoka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871xnvh94z.fsf@xenon.eswe.dyndns.org \
--to=s.wi@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).