From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/56734 Path: main.gmane.org!not-for-mail From: Stefan Wiens Newsgroups: gmane.emacs.gnus.general Subject: In gnus-sum.el: Incorrect handling of sparse articles Date: Sun, 14 Mar 2004 14:05:00 +0100 Organization: lieber nicht Sender: ding-owner@lists.math.uh.edu Message-ID: <871xnvh94z.fsf@xenon.eswe.dyndns.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1079280957 23085 80.91.224.253 (14 Mar 2004 16:15:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 14 Mar 2004 16:15:57 +0000 (UTC) Original-X-From: ding-owner+M5273@lists.math.uh.edu Sun Mar 14 17:15:49 2004 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B2YHE-0006Qz-00 for ; Sun, 14 Mar 2004 17:15:48 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 1B2YGf-0005VL-00; Sun, 14 Mar 2004 10:15:13 -0600 Original-Received: from justine.libertine.org ([66.139.78.221] ident=postfix) by malifon.math.uh.edu with esmtp (Exim 3.20 #1) id 1B2VIx-00054W-00 for ding@lists.math.uh.edu; Sun, 14 Mar 2004 07:05:23 -0600 Original-Received: from quimby.gnus.org (quimby.gnus.org [80.91.224.244]) by justine.libertine.org (Postfix) with ESMTP id 258ED3A0039 for ; Sun, 14 Mar 2004 07:05:22 -0600 (CST) Original-Received: from news by quimby.gnus.org with local (Exim 3.35 #1 (Debian)) id 1B2VIv-0002WW-00 for ; Sun, 14 Mar 2004 14:05:21 +0100 Original-To: ding@gnus.org Original-Path: xenon.eswe.dyndns.org!nobody Original-Newsgroups: gnus.ding Original-Lines: 34 Original-NNTP-Posting-Host: 1cust100.tnt2.hnr2.deu.da.uu.net Original-X-Trace: quimby.gnus.org 1079269521 9703 149.225.110.100 (14 Mar 2004 13:05:21 GMT) Original-X-Complaints-To: usenet@quimby.gnus.org Original-NNTP-Posting-Date: Sun, 14 Mar 2004 13:05:21 +0000 (UTC) User-Agent: Gnus/5.1006 (Gnus v5.10.6) Emacs/21.2 (gnu/linux) Cancel-Lock: sha1:EWBHmOMRED4/Eg5ZhZMobOtNUvQ= Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:56734 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:56734 Hi, in gnus-sum.el, function gnus-read-header: (defun gnus-read-header (id &optional header) "Read the headers of article ID and enter them into the Gnus system." [...] ;; If this is a sparse article, we have to nix out its ;; previous entry in the thread hashtb. (when (and header (gnus-summary-article-sparse-p (mail-header-number header))) (let* ((parent (gnus-parent-id (mail-header-references header))) (thread (and parent (gnus-id-to-thread parent)))) (when thread (delq (assq header thread) thread)))) ^^^^ That `delq' operation trashes the thread structure in the gnus-newsgroup-dependencies table. In contrast to the comment, it does not remove the "previous entry" from the table, but causes the thread to be split. Is this (supposed) "expunging" really necessary? If the sparse header is left in place, gnus-get-newsgroup-headers will simply replace it. I believe that weird code causes the long-standing problems with `^', `A T', `A R' when gnus-build-sparse-threads is set to e. g. 'some. I am currently testing with the offending code (cited above) commented out, and everything seems to work fine. Stefan