From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/51922 Path: main.gmane.org!not-for-mail From: Jon Ericson Newsgroups: gmane.emacs.gnus.general Subject: Re: How many people mark spam in gmane groups? Date: Mon, 28 Apr 2003 11:36:43 -0700 Sender: ding-owner@lists.math.uh.edu Message-ID: <871xzmqxj8.fsf@jpl.nasa.gov> References: <4n4r5aowwm.fsf@chubby.bwh.harvard.edu> <4n4r4y1jx8.fsf@lockgroove.bwh.harvard.edu> <87r87qq8ff.fsf@jpl.nasa.gov> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1051555032 821 80.91.224.249 (28 Apr 2003 18:37:12 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 28 Apr 2003 18:37:12 +0000 (UTC) Original-X-From: ding-owner+M465@lists.math.uh.edu Mon Apr 28 20:37:11 2003 Return-path: Original-Received: from malifon.math.uh.edu ([129.7.128.13]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19ADV0-0000D4-00 for ; Mon, 28 Apr 2003 20:37:10 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 19ADV2-0002Ky-00; Mon, 28 Apr 2003 13:37:12 -0500 Original-Received: from sclp3.sclp.com ([64.157.176.121]) by malifon.math.uh.edu with smtp (Exim 3.20 #1) id 19ADUs-0002Ks-00 for ding@lists.math.uh.edu; Mon, 28 Apr 2003 13:37:04 -0500 Original-Received: (qmail 30252 invoked by alias); 28 Apr 2003 18:36:59 -0000 Original-Received: (qmail 30246 invoked from network); 28 Apr 2003 18:36:58 -0000 Original-Received: from main.gmane.org (80.91.224.249) by sclp3.sclp.com with SMTP; 28 Apr 2003 18:36:58 -0000 Original-Received: from list by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19ADTh-0008WO-00 for ; Mon, 28 Apr 2003 20:35:49 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-To: ding@gnus.org Original-Received: from news by main.gmane.org with local (Exim 3.35 #1 (Debian)) id 19ADTh-0008WF-00 for ; Mon, 28 Apr 2003 20:35:49 +0200 Original-Lines: 62 Original-X-Complaints-To: usenet@main.gmane.org User-Agent: Gnus/5.090019 (Oort Gnus v0.19) XEmacs/21.4 (Native Windows TTY Support (Windows), cygwin32) X-Face: "Ro}i#1h*rV:tg+F.!]r/y,RDL'`*sc[_1LB'%*akh@LHbt,:gBJ/:2cS@:hpBLtYO)o3a; w3Tli`r,.jIZD-zR)p7:^V^}#Wz@.\av>O{!8S.h>lnL3eMT1",~EiISLm4rw/*qVW3xE#vj4}#Cq' 57,?HW3K-Hl.B+&{=>+e;R:J~'tJ*~fS*2n-G_8_5eS[w?#*JF~tj#~=zglo*\&YBS1&Zr2gP] Cancel-Lock: sha1:Rlr1Ui+qJKC+45O0jZFhYrp+8Gw= Precedence: bulk Xref: main.gmane.org gmane.emacs.gnus.general:51922 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:51922 Lars Magne Ingebrigtsen writes: > Jon Ericson writes: > >> I just sent a message that reports that spam-report.el works, but I >> might have spoken too soon. I used gmane.test to mark three messages >> as spam. When I quit the summary buffer the messages from spam-report >> showed all three message numbers were reported to Gmane. But the >> Gmane approval page showed only the last article reported three times. > > Hm... perhaps the changes I made weren't foolproof, anyway. > > Do you have a way to reproduce this by, er, more reproducible means? > For instance, three wgets fired off in sequence? Ok. Testing from Gnus shows that just two articles are enough to cause the bug. It seems something like this: wget http://spam.gmane.org/gmane.test:615 http://spam.gmane.org/gmane.test:625 does not trigger the bug. Looks like Gmane is off the hook. Then I went back to Gnus and used spam-report to mark those articles as spam, saw a message about reporting 615 to Gmane, and when I looked at http://gmane.org/approve.php I found that article 609 in that group was reported as spam twice by me. After setting spam-report-gmane-use-article-number to nil, the bug disappears. Here's the bit of code from spam-report.el that this variable toggles: (spam-report-url-ping "spam.gmane.org" (format "/%s:%d" (gnus-group-real-name gnus-newsgroup-name) (gnus-summary-article-number))) I think that (gnus-summary-article-number) is the problem. From help: `gnus-summary-article-number' is a compiled Lisp macro -- loaded from "gnus-sum" (gnus-summary-article-number) Documentation: The article number of the article on the current line. If there isn't an article number here, then we return the current article number. This isn't really what we want in this case, since it will return the same article number each time it's called. Should that branch of code be eliminated? The only reason given for it is speed, which really doesn't seem to be a problem in the first place. Looks like I'm learning lisp in spite of myself. :) Jon -- Everyone who does evil hates the light, and will not come into the light for fear that his deeds will be exposed. But whoever lives by the truth comes into the light, so that it may be seen plainly that what he has done has been done through God." -- John 3:20-21 (NIV)