From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: from mx1.math.uh.edu (mx1.math.uh.edu [129.7.128.32]) by inbox.vuxu.org (Postfix) with ESMTP id 2972F241CD for ; Fri, 2 Feb 2024 00:43:24 +0100 (CET) Received: from lists1.math.uh.edu ([129.7.128.208]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1rVgiD-000000042HK-2F07 for ml@inbox.vuxu.org; Thu, 01 Feb 2024 17:43:17 -0600 Received: from lists1.math.uh.edu ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.97.1) (envelope-from ) id 1rVgiD-0000000476e-01Vb for ml@inbox.vuxu.org; Thu, 01 Feb 2024 17:43:17 -0600 Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtp (Exim 4.97.1) (envelope-from ) id 1rVgiB-0000000476V-0kAQ for ding@lists.math.uh.edu; Thu, 01 Feb 2024 17:43:15 -0600 Received: from quimby.gnus.org ([95.216.78.240]) by mx1.math.uh.edu with esmtps (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1rVfeO-000000041qa-1g2B for ding@lists.math.uh.edu; Thu, 01 Feb 2024 16:35:19 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:Mime-Version:References :Message-ID:Date:Subject:From:To:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=D0EvKDfNuoZPxPGrqzgVrK5kWly5BiPFJl9xcXDzSrk=; b=Tnc7kb4+H8rN7yyTJ+G7/hMYy8 JT7tAp45gkZMz2xy7XtGOO8dqMUr2KcURTOrFpJNEJKOfJgILBEqmg9p0L6j/epOWHTAyezCf4hYk Xwq2SA9Z8Ft9IKu5raKvly9kTvUYFPUTOiLPYpPJJcYFXdYDE7dVzS6InN+rCgjDCimc=; Received: from ciao.gmane.io ([116.202.254.214]) by quimby.gnus.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rVfeC-0006sS-H7 for ding@gnus.org; Thu, 01 Feb 2024 23:35:06 +0100 Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1rVfe9-0002r0-QE for ding@gnus.org; Thu, 01 Feb 2024 23:35:01 +0100 X-Injected-Via-Gmane: http://gmane.org/ To: ding@gnus.org From: Eric Abrahamsen Subject: Re: problem with (display . [not expire]) with git emacs Date: Thu, 01 Feb 2024 14:33:03 -0800 Message-ID: <8734ubke74.fsf@ericabrahamsen.net> References: <87v879qn62.fsf@uwo.ca> <87jznpqdep.fsf@uwo.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable User-Agent: Gnus/5.13 (Gnus v5.13) Cancel-Lock: sha1:lxZys49aJmsmBM4T7qG4dPtSTn4= List-ID: Precedence: bulk Dan Christensen writes: > Two additional things. First, I should have said that Gnus does not > raise an error. It just silently ignores my [not expire] setting. > > Second, here is a link to the relevant commit, which shows the diff: > > https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=3D8525be6d5eca0c75= 008ec1dc799cae537156feea > > Is anyone else using git emacs since Nov 29 and also using (display > . [not expire])? > > Dan > > On Jan 31, 2024, Dan Christensen wrote: > >> I'm using Gnus with git emacs, and noticed that since commit 8525be6d >> from Nov 29, 2023 (see below), Gnus isn't honouring my group parameter >> >> (display . [not expire]) >> >> I used the debugger to find that there is an error involving >> byte-compilation. The top of the debug output contains: >> >> Debugger entered--returning value: "Malformed function =E2=80=98#[0 \"\\= 301\\300!\\207\" [expire gnus-article-marked-p] 2]=E2=80=99" >> format-message("Malformed function `%S'" #f(compiled-function () #)) >> * #f(compiled-function (form env extend func forms) #)(((#f(compiled-function () #))) (nil) (= nil) #f(compiled-function () #) nil) >> >> and an earlier call that could probably be used to reproduce this is: >> >> * gnus-summary-display-make-predicate((not expire)) >> >> The full stack trace is below, as is the text of the commit. >> >> Can anyone else using git emacs more recent than Nov 29 tell me >> whether (display . [not expire]) is working for them? Note that >> (display . [expire]) *does* seem to work correctly. >> >> If we determine that it's not just a quirk in my set-up, I could move >> this discussion to an emacs list, but I thought I would start here. >> >> Dan >> >> The commit that is causing trouble is: >> >> commit 8525be6d5eca0c75008ec1dc799cae537156feea (HEAD, refs/bisect/bad) >> Author: Mattias Engdeg=C3=A5rd >> Date: Wed Nov 29 17:51:46 2023 +0100 >> >> Move malformed-function warning from byte-opt to cconv (bug#67483) >> >> We shouldn't be warning inside the optimiser in the first place. >> >> * lisp/emacs-lisp/byte-opt.el (byte-optimize-form): >> Remove byte-compile-form-stack manipulation. >> (byte-optimize-form-code-walker): Move malformed function warning >> from here... >> * lisp/emacs-lisp/cconv.el: ...to here. >> >> The backtrace: >> >> Debugger entered--returning value: "Malformed function =E2=80=98#[0 \"\\= 301\\300!\\207\" [expire gnus-article-marked-p] 2]=E2=80=99" >> format-message("Malformed function `%S'" #f(compiled-function () #)) >> * #f(compiled-function (form env extend func forms) #)(((#f(compiled-function () #))) (nil) (= nil) #f(compiled-function () #) nil) >> * cconv-convert((#f(compiled-function () #)) ni= l nil) >> * #f(compiled-function (form) #)((#f(compil= ed-function () #))) >> * mapcar(#f(compiled-function (form) #) ((#= f(compiled-function () #)))) >> * #f(compiled-function (form env extend func forms) #)(((not (#f(compiled-function () #)))) (= nil) (nil) not ((#f(compiled-function () #)))) >> * cconv-convert((not (#f(compiled-function () #= ))) nil nil) >> * #f(compiled-function (form) #)((not (#f(co= mpiled-function () #)))) >> * mapcar(#f(compiled-function (form) #) ((no= t (#f(compiled-function () #))))) >> * cconv--convert-funcbody(nil ((not (#f(compiled-function () #)))) nil #'(lambda nil (not (#f(compiled-function () #))))) >> * cconv--convert-function(nil ((not (#f(compiled-function () #)))) nil #'(lambda nil (not (#f(compiled-function () #)))) nil) >> * cconv-convert(#'(lambda nil (not (#f(compiled-function () #)))) nil nil) >> * cconv-closure-convert(#'(lambda nil (not (#f(compiled-function () #)))) nil) >> * byte-compile-preprocess((lambda nil (not (#f(compiled-function () #))))) >> * #f(compiled-function (form) #)((lambda ni= l (not (#f(compiled-function () #))))) >> * byte-compile((lambda nil (not (#f(compiled-function () #))))) >> * gnus-byte-compile((lambda nil (not (#f(compiled-function () #))))) >> * gnus-category-make-function((not expire)) >> * gnus-get-predicate((not expire)) >> * gnus-summary-display-make-predicate((not expire)) >> * (cond ((not (=3D 0 (or (car-safe read-all) 0))) #'gnus-not-ignore) ((e= q display 'all) #'gnus-not-ignore) ((arrayp display) (gnus-summary-display-= make-predicate (mapcar #'identity display))) ((numberp display) (setq selec= t-articles (range-uncompress (cons (let ((tmp ...)) (if (> tmp 0) tmp 1)) (= cdr (gethash group gnus-active-hashtb))))) nil) (t nil)) >> * (setq gnus-newsgroup-display (cond ((not (=3D 0 (or (car-safe read-all= ) 0))) #'gnus-not-ignore) ((eq display 'all) #'gnus-not-ignore) ((arrayp di= splay) (gnus-summary-display-make-predicate (mapcar #'identity display))) (= (numberp display) (setq select-articles (range-uncompress (cons (let (...) = (if ... tmp 1)) (cdr (gethash group gnus-active-hashtb))))) nil) (t nil))) >> (let ((display (gnus-group-find-parameter group 'display))) (debug) (s= etq gnus-newsgroup-display (cond ((not (=3D 0 (or (car-safe read-all) 0))) = #'gnus-not-ignore) ((eq display 'all) #'gnus-not-ignore) ((arrayp display) = (gnus-summary-display-make-predicate (mapcar #'identity display))) ((number= p display) (setq select-articles (range-uncompress (cons (let ... ...) (cdr= ...)))) nil) (t nil)))) >> (let* ((entry (gethash group gnus-newsrc-hashtb)) (gnus-summary-ignore= -duplicates (if (eq (car (gnus-find-method-for-group group)) 'nnvirtual) t = gnus-summary-ignore-duplicates)) (info (nth 1 entry)) articles fetched-arti= cles cached) (if (gnus-check-server (set (make-local-variable 'gnus-current= -select-method) (gnus-find-method-for-group group))) nil (error "Couldn't o= pen server")) (or (and entry (not (eq (car entry) t))) (gnus-activate-group= group) (progn (if (derived-mode-p 'gnus-summary-mode) (progn (gnus-kill-bu= ffer (current-buffer)))) (error "Couldn't activate group %s: %s" group (gnu= s-status-message group)))) (if (gnus-request-group group t nil info) nil (i= f (derived-mode-p 'gnus-summary-mode) (progn (gnus-kill-buffer (current-buf= fer)))) (error "Couldn't request group %s: %s" group (gnus-status-message g= roup))) (if (and gnus-agent (gethash group gnus-active-hashtb)) (progn (gnu= s-agent-possibly-alter-active group (gethash group gnus-active-hashtb) info= ) (setq gnus-summary-use-undownloaded-faces (gnus-agent-find-parameter grou= p 'agent-enable-undownloaded-faces)))) (progn (setq gnus-newsgroup-name gro= up) (setq gnus-newsgroup-unselected nil) (setq gnus-newsgroup-unreads (gnus= -list-of-unread-articles group))) (let ((display (gnus-group-find-parameter= group 'display))) (debug) (setq gnus-newsgroup-display (cond ((not (=3D 0 = (or ... 0))) #'gnus-not-ignore) ((eq display 'all) #'gnus-not-ignore) ((arr= ayp display) (gnus-summary-display-make-predicate (mapcar #'identity displa= y))) ((numberp display) (setq select-articles (range-uncompress (cons ... .= ..))) nil) (t nil)))) (gnus-summary-setup-default-charset) (if (gnus-virtua= l-group-p group) (progn (setq cached gnus-newsgroup-cached))) (setq gnus-ne= wsgroup-unreads (gnus-sorted-ndifference (gnus-sorted-ndifference gnus-news= group-unreads gnus-newsgroup-marked) gnus-newsgroup-dormant)) (setq gnus-ne= wsgroup-processable nil) (gnus-update-read-articles group gnus-newsgroup-un= reads t) (if info (progn (gnus-adjust-marked-articles info))) (if (setq art= icles select-articles) (setq gnus-newsgroup-unselected (gnus-sorted-differe= nce gnus-newsgroup-unreads articles)) (setq articles (gnus-articles-to-read= group read-all))) (cond ((null articles) 'quit) ((eq articles 0) nil) (t (= setq gnus-newsgroup-dependencies (gnus-make-hashtable (length articles))) (= if (gnus-buffer-live-p gnus-group-buffer) (gnus-set-global-variables) (set-= default 'gnus-newsgroup-name gnus-newsgroup-name)) (setq gnus-newsgroup-hea= ders (gnus-fetch-headers articles)) (if cached (progn (setq gnus-newsgroup-= cached cached))) (if gnus-suppress-duplicates (progn (gnus-dup-suppress-art= icles))) (setq gnus-newsgroup-limit (copy-sequence articles)) (setq fetched= -articles (mapcar #'mail-header-number gnus-newsgroup-headers)) (setq gnus-= newsgroup-articles fetched-articles) (setq gnus-newsgroup-unreads (gnus-sor= ted-nintersection gnus-newsgroup-unreads fetched-articles)) (gnus-compute-u= nseen-list) (gnus-update-missing-marks (gnus-sorted-difference articles fet= ched-articles)) (if (and gnus-fetch-old-headers (eq gnus-headers-retrieved-= by 'nov)) (progn (if (eq gnus-fetch-old-headers 'invisible) (gnus-build-all= -threads) (gnus-build-old-threads)))) (if gnus-agent (progn (gnus-agent-get= -undownloaded-list))) (gnus-summary-remove-list-identifiers) (setq gnus-new= sgroup-auto-expire (and (gnus-group-auto-expirable-p group) (not (gnus-grou= p-read-only-p group)))) (if (and gnus-single-article-buffer (equal gnus-art= icle-buffer "*Article*")) nil (gnus-article-setup-buffer)) (if gnus-newsgro= up-headers (progn (progn (setq gnus-newsgroup-begin (let* ... ...)) (setq g= nus-newsgroup-end (let* ... ...))))) (or gnus-newsgroup-headers t)))) >> gnus-select-newsgroup("nnimap+rocky:INBOX" 9 nil) >> gnus-summary-read-group-1("nnimap+rocky:INBOX" 9 t nil nil nil) >> gnus-summary-read-group("nnimap+rocky:INBOX" 9 t nil nil nil nil) >> gnus-group-read-group(9 t "nnimap+rocky:INBOX") >> jdc-gnus-group-select-inbox(9) >> funcall-interactively(jdc-gnus-group-select-inbox 9) >> call-interactively(jdc-gnus-group-select-inbox nil nil) >> command-execute(jdc-gnus-group-select-inbox) Oh, of course, here's where the function cache comes from: (unless gnus-summary-display-cache (dolist (elem (append '((unread . unread) (read . read) (unseen . unseen)) gnus-article-mark-lists)) (push (cons (cdr elem) (let ((x (cdr elem))) (lambda () (gnus-article-marked-p x)))) gnus-summary-display-cache))) So the bytecode is for (lambda () (gnus-article-marked-p 'expire)).