From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/88157 Path: news.gmane.org!.POSTED!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.gnus.general Subject: Re: inline Date: Mon, 08 Oct 2018 10:06:02 -0700 Message-ID: <8736tg2wsl.fsf@ericabrahamsen.net> References: <86lg78plq7.fsf@zoho.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1539018325 675 195.159.176.226 (8 Oct 2018 17:05:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 8 Oct 2018 17:05:25 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) To: ding@gnus.org Original-X-From: ding-owner+M36371@lists.math.uh.edu Mon Oct 08 19:05:21 2018 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from lists1.math.uh.edu ([129.7.128.208]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9Yy7-0008Uq-Q9 for ding-account@gmane.org; Mon, 08 Oct 2018 19:05:19 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.90_1) (envelope-from ) id 1g9Z0B-0006z2-TS; Mon, 08 Oct 2018 12:07:27 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by lists1.math.uh.edu with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1g9Z03-0006w9-KY for ding@lists.math.uh.edu; Mon, 08 Oct 2018 12:07:19 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.90_1) (envelope-from ) id 1g9Z02-0007CJ-23 for ding@lists.math.uh.edu; Mon, 08 Oct 2018 12:07:19 -0500 Original-Received: from [195.159.176.226] (helo=blaine.gmane.org) by quimby.gnus.org with esmtp (Exim 4.84_2) (envelope-from ) id 1g9Z00-0004BL-T9 for ding@gnus.org; Mon, 08 Oct 2018 19:07:16 +0200 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1g9Yxt-0008Ex-EL for ding@gnus.org; Mon, 08 Oct 2018 19:05:05 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 27 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:HoHG10PtwxxKTjtiJHG8fbPlk9c= X-Spam-Score: 1.0 (+) X-Spam-Report: SpamAssassin (3.4.2 2018-09-13) analysis follows Bayesian score: 0.3076 Ham tokens: 0.000-177--6819h-0s--0d--H*M:fsf, 0.000-30--1147h-0s--0d--H*UA:Emacs, 0.000-30--1130h-0s--0d--H*u:Emacs, 0.000-24--904h-0s--0d--H*UA:Gnus, 0.000-24--903h-0s--0d--H*u:Gnus Spam tokens: 0.997-34667--621h-27510s--0d--H*r:quimby.gnus.org, 0.995-35687--1037h-28630s--0d--HTo:D*gnus.org, 0.995-36829--1142h-29602s--0d--H*RU:quimby.gnus.org, 0.995-36829--1142h-29602s--0d--Hx-spam-relays-external:quimby.gnus.org, 0.994-36806--1306h-29712s--0d--Hx-spam-relays-internal:quimby.gnus.org Autolearn status: no autolearn_force=no -0.0 BAYES_40 BODY: Bayes spam probability is 20 to 40% [score: 0.3076] 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:88157 Archived-At: Emanuel Berg writes: > On gnu.emacs.help, there has been a long > discussion on inlining functions. > > Just now, I wrote > > If you have studied the Gnus source code, > you find that the defuns are insanely long. > They go on all but forever. This is because > Gnus is already slow, and perhaps Elisp is > as well, so they don't want to brake it up > into modules (smaller defuns) because then > it would require the funcall overhead. > Perhaps Gnus would benefit from > inlining stuff? > > But be sure to check out the entire thread. > There has been lots of changes to the subject > line so there are several threads all dealing > with the inline stuff. FWIW, I think Gnus would gain the most not by inlining more code, but by adjusting its data structures, and introducing more caching at higher levels. So much of the code is simply boilerplate for finding things, or gathering data together, and doing it repeatedly. I think that's where most of the win would be.