From: Tassilo Horn <tassilo@member.fsf.org>
To: ding@gnus.org
Subject: Re: Mass removal of unused Gnus functions
Date: Wed, 25 Jul 2012 14:21:40 +0200 [thread overview]
Message-ID: <87394ghvzf.fsf@thinkpad.tsdh.de> (raw)
In-Reply-To: <87a9youjyt.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Wed, 25 Jul 2012 14:02:50 +0200")
Julien Danjou <julien@danjou.info> writes:
>> your commit 992509a3574f9add376cc480db9bb5656285bd5b removed lots of
>> dead code, but at least `gnus-kill-sticky-article-buffers' was not as
>> dead as you've suspected.
>>
>> It is a user frontend function that's also documented in the manual.
>> It's never called internally, and it's not even bound to a key
>> because it's not really connected to any gnus mode.
>
> Good catch. I was sure there would be one or two mistakes in the whole
> patch, but I think it was worth it anyway, and was ready to respond to
> my mistake! ;)
Yes, sure, removing cruft is almost always a good thing. And one false
positive in more than a dozen functions is not so bad.
> I restored the function, thank for notifying me, and sorry for
> disturbing. :)
No problem.
Bye,
Tassilo
next prev parent reply other threads:[~2012-07-25 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 6:40 Tassilo Horn
2012-07-25 12:02 ` Julien Danjou
2012-07-25 12:21 ` Tassilo Horn [this message]
2012-09-04 22:49 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87394ghvzf.fsf@thinkpad.tsdh.de \
--to=tassilo@member.fsf.org \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).