From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/82084 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.gnus.general Subject: Re: Mass removal of unused Gnus functions Date: Wed, 25 Jul 2012 14:21:40 +0200 Message-ID: <87394ghvzf.fsf@thinkpad.tsdh.de> References: <87pq7kjqd7.fsf@thinkpad.tsdh.de> <87a9youjyt.fsf@keller.adm.naquadah.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1343218927 2492 80.91.229.3 (25 Jul 2012 12:22:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 25 Jul 2012 12:22:07 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M30354@lists.math.uh.edu Wed Jul 25 14:22:06 2012 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Su0bO-0001zf-63 for ding-account@gmane.org; Wed, 25 Jul 2012 14:22:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Su0bE-0007WV-VS; Wed, 25 Jul 2012 07:21:57 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Su0bD-0007WL-Re for ding@lists.math.uh.edu; Wed, 25 Jul 2012 07:21:55 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1Su0b3-0007nB-Bz for ding@lists.math.uh.edu; Wed, 25 Jul 2012 07:21:55 -0500 Original-Received: from deliver.uni-koblenz.de ([141.26.64.15]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1Su0b1-0004G8-La for ding@gnus.org; Wed, 25 Jul 2012 14:21:43 +0200 Original-Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 08701D2386 for ; Wed, 25 Jul 2012 14:21:43 +0200 (CEST) X-Virus-Scanned: amavisd-new at uni-koblenz.de Original-Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kxmErjSOk-zX for ; Wed, 25 Jul 2012 14:21:42 +0200 (CEST) X-CHKRCPT: Envelopesender noch tassilo@member.fsf.org Original-Received: from thinkpad.tsdh.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 3BF74D2397 for ; Wed, 25 Jul 2012 14:21:40 +0200 (CEST) In-Reply-To: <87a9youjyt.fsf@keller.adm.naquadah.org> (Julien Danjou's message of "Wed, 25 Jul 2012 14:02:50 +0200") User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.1.50 (gnu/linux) X-Spam-Score: -4.9 (----) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:82084 Archived-At: Julien Danjou writes: >> your commit 992509a3574f9add376cc480db9bb5656285bd5b removed lots of >> dead code, but at least `gnus-kill-sticky-article-buffers' was not as >> dead as you've suspected. >> >> It is a user frontend function that's also documented in the manual. >> It's never called internally, and it's not even bound to a key >> because it's not really connected to any gnus mode. > > Good catch. I was sure there would be one or two mistakes in the whole > patch, but I think it was worth it anyway, and was ready to respond to > my mistake! ;) Yes, sure, removing cruft is almost always a good thing. And one false positive in more than a dozen functions is not so bad. > I restored the function, thank for notifying me, and sorry for > disturbing. :) No problem. Bye, Tassilo