Gnus development mailing list
 help / color / mirror / Atom feed
From: Andrew Cohen <cohen@andy.bu.edu>
To: ding@gnus.org
Subject: Re: A T does not work in nnml ...
Date: Wed, 03 Nov 2010 19:49:21 -0400	[thread overview]
Message-ID: <8739ri6k8u.fsf@andy.bu.edu> (raw)
In-Reply-To: <m3zktrjyr0.fsf@quimbies.gnus.org>

>>>>> "Lars" == Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

    Lars> Andrew Cohen <cohen@andy.bu.edu> writes:
    >> Thread-referral has always been sub-optimal for nnml. The current
    >> (and previous) behavior is to just download a bunch of headers
    >> and hope that the thread is among them. For nnml I suspect there
    >> is a better way...

    Lars> Perhaps the number of headers it downloads should be doubled
    Lars> or something?

Hmm, it appears there is an underlying bug which manifests whenever the
headers are retrieved as nov.  I kind of know what's going on but I
don't yet fully understand the way dependencies work.

The Problem:
Even when the headers for the articles in the thread have been retrieved
the articles don't make their way into the summary buffer. 

"A T" (aka gnus-summary-refer-thread) retrieves the headers, calls
gnus-build-all-threads and finally
gnus-summary-limit-include-thread. Now gnus-build-all-threads parses
each header (in nov format) and calls gnus-dependencies-add-header. This
function checks to see if the header is already in the dependencies
hash. If not, it adds it and then pushes the header onto
gnus-newsgroup-headers. If the header is already present it just skip
these steps.

This is the problem---there may already be an entry in the dependencies
list if the article is already present but refers to other articles in
the thread that haven't yet been retrieved. But then the article id of
these "other" articles is a negative number (reflecting the fact that
they haven't been retrieved) and never gets updated to the actual
article id. And the newly fetched headers for these articles doesn't get
pushed onto gnus-newsgroup-headers, hence the problem.

I thought I could fix it by calling gnus-dependencies-add-header with
the force-new flag. This works better, but still shows some odd
behavior. 

I'll keep plugging away at this, but someone who knows more about
dependencies and threading might find the fix faster.







  reply	other threads:[~2010-11-03 23:49 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02  9:45 Ulf Stegemann
2010-11-02 14:50 ` Andrew Cohen
2010-11-02 15:35   ` Ulf Stegemann
2010-11-02 15:38     ` Andrew Cohen
2010-11-02 19:45   ` Lars Magne Ingebrigtsen
2010-11-03 23:49     ` Andrew Cohen [this message]
2010-11-04  1:29       ` Andrew Cohen
2010-11-04 15:38         ` Andrew Cohen
2010-11-04 20:31           ` Steinar Bang
2010-11-05 18:15             ` Andrew Cohen
2010-11-05 20:25               ` Steinar Bang
2010-11-05 23:40                 ` Andrew Cohen
2010-11-06  8:15                   ` Steinar Bang
2010-11-06  8:29                     ` Steinar Bang
2010-11-06 11:36                       ` Andrew Cohen
2010-11-06 17:32                         ` Steinar Bang
2010-11-04 20:39           ` Lars Magne Ingebrigtsen
2010-11-06 15:55   ` Andrew Cohen
2010-11-06 18:20     ` Steinar Bang
2010-11-06 19:18       ` Andrew Cohen
2010-11-06 21:13         ` Steinar Bang
2010-11-07  0:35           ` Andrew Cohen
2010-11-07  6:13             ` Steinar Bang
2010-11-07  6:54               ` Steinar Bang
2010-11-07 13:09                 ` Andrew Cohen
2010-11-07 15:09                   ` Steinar Bang
2010-11-07 16:17                     ` Steinar Bang
2010-11-07 17:15                       ` Andrew Cohen
2010-11-07 18:23                         ` Steinar Bang
2010-11-07 18:33                           ` Steinar Bang
2010-11-07 18:56                             ` Steinar Bang
2010-11-14 16:46                               ` A T hangs forever in gmane nntp (Was: A T does not work in nnml ...) Steinar Bang
2010-11-14 17:59                                 ` A T hangs forever in gmane nnir (Was: A T hangs forever in gmane nntp) Steinar Bang
2010-11-14 20:25                                   ` A T hangs forever in gmane nnir Steinar Bang
2010-11-15 20:23                                     ` Steinar Bang
2010-11-08  8:08     ` A T does not work in nnml Ulf Stegemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8739ri6k8u.fsf@andy.bu.edu \
    --to=cohen@andy.bu.edu \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).