Re: nnimap issues

[Simon Josefsson <simon@josefsson.org>]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Lars Magne Ingebrigtsen <larsi@gnus.org> writes:
>
>> Yes, it should check the capabilites and auto-STARTTLS if it's
>> available, I guess?
>
> Looking at this, we have to decide whether to start doing STARTTLS
> before we get to the server -- we have to open the connection with
> `starttls-open-stream', which requires an external program (or the
> internal support Ted is working on), and can't just start with a simple
> network connection and then switch if it turns out that the server
> really supports STARTTLS.  Unfortunately.
>
> I think.

The old code opened a native elisp network connection, and upon noticing
the STARTTLS capability, re-opened the connection using starttls.el and
then upgraded that connection.  This was actually all done by imap.el,
and nnimap.el was not involved at all -- the only necessary thing is
that nnimap let imap.el auto-detect the stream to use by not providing a
imap-stream unless specified by the user.  See old code in imap-open:

...
    (message "imap: Connecting to %s..." imap-server)
    (if (null (let ((imap-stream (or imap-stream imap-default-stream)))
		(imap-open-1 buffer)))
	(progn
	  (message "imap: Connecting to %s...failed" imap-server)
	  nil)
      (when (null imap-stream)
	;; Need to choose stream.
	(let ((streams imap-streams))
	  (while (setq stream (pop streams))
	    ;; OK to use this stream?
	    (when (funcall (nth 1 (assq stream imap-stream-alist)) buffer)
	      ;; Stream changed?
	      (if (not (eq imap-default-stream stream))
		  (with-current-buffer (get-buffer-create
					(generate-new-buffer-name " *temp*"))
		    (mapc 'make-local-variable imap-local-variables)
		    (imap-disable-multibyte)
		    (buffer-disable-undo)
		    (setq imap-server (or server imap-server))
		    (setq imap-port (or port imap-port))
		    (setq imap-auth (or auth imap-auth))
		    (message "imap: Reconnecting with stream `%s'..." stream)
...

/Simon