Gnus development mailing list
 help / color / mirror / Atom feed
From: Simon Josefsson <simon@josefsson.org>
To: Dave Love <fx@gnu.org>, ding@gnus.org
Subject: Disallow ;;) smileys
Date: Tue, 24 Mar 2009 10:06:11 +0100	[thread overview]
Message-ID: <873ad3xpbw.fsf@mocca.josefsson.org> (raw)

I've been bugged one too many times that the following line will display
with a smiley when viewed in Gnus:

   for (;;)

It doesn't seem like ;;) is ever a useful smiley, or is there?

So I propose the patch below.  How about it?  I can commit it if you
want.

Thanks,
Simon

2009-03-24  Simon Josefsson  <simon@josefsson.org>

	* smiley.el (smiley-regexp-alist): Disallow ;;) from being treated as a
	blink smiley.

--- smiley.el.~7.25.~	2009-02-03 14:56:15.000000000 +0100
+++ smiley.el	2009-03-24 10:02:13.000000000 +0100
@@ -102,7 +102,8 @@
 
 ;; The XEmacs version has a baroque, if not rococo, set of these.
 (defcustom smiley-regexp-alist
-  '(("\\(;-?)\\)\\W" 1 "blink")
+  '(("\\(;-)\\)\\W" 1 "blink")
+    ("\\([^;];)\\)\\W" 1 "blink")
     ("\\(:-]\\)\\W" 1 "forced")
     ("\\(8-)\\)\\W" 1 "braindamaged")
     ("\\(:-|\\)\\W" 1 "indifferent")



             reply	other threads:[~2009-03-24  9:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-24  9:06 Simon Josefsson [this message]
2009-03-26  4:56 ` Miles Bader
2010-08-29 22:27   ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873ad3xpbw.fsf@mocca.josefsson.org \
    --to=simon@josefsson.org \
    --cc=ding@gnus.org \
    --cc=fx@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).