nnweb vs. mm-url

nnweb vs. mm-url

[Andreas Seltenreich]

[-- Attachment #1: Type: text/plain, Size: 1236 bytes --]

Hi,

does anyone know why mm-url is explicitly setting a "Connection"
header on all requests? The ChangeLog doesn't contain any hints why it
was added. It seems to confuse url-http.el of Emacs 22, since it ships
two "Connection" headers with contradicting values:

--8<---------------cut here---------------start------------->8---
tcpdump -i eth0 -X -s 0 port\ http
[...]
 12:47:53.034094 IP tp.42794 > 64.233.167.147.www: P 833:1707(874) ack 906 win 7232
[...]
        0x00b0:  7273 696f 6e3a 2031 2e30 0d0a 436f 6e6e  rsion:.1.0..Conn
        0x00c0:  6563 7469 6f6e 3a20 6b65 6570 2d61 6c69  ection:.keep-ali
        0x00d0:  7665 0d0a 4578 7465 6e73 696f 6e3a 2053  ve..Extension:.S
[...]
        0x0370:  782d 676e 753b 2058 3131 290d 0a43 6f6e  x-gnu;.X11)..Con
        0x0380:  6e65 6374 696f 6e3a 2043 6c6f 7365 0d0a  nection:.Close..
        0x0390:  0d0a                                     ..
--8<---------------cut here---------------end--------------->8---

Applying the following patch makes nnweb.el fully functional for me on
Emacs 22 with mm-url-use-external set to nil. Without it, referring
articles using internal fetching appears to be break when url-http
tries to recycle the connection when following redirects.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: mm-url.patch --]
[-- Type: text/x-patch, Size: 605 bytes --]

Index: mm-url.el
===================================================================
RCS file: /usr/local/cvsroot/gnus/lisp/mm-url.el,v
retrieving revision 7.13
diff -c -r7.13 mm-url.el
*** mm-url.el	20 Jan 2006 08:35:06 -0000	7.13
--- mm-url.el	22 Apr 2006 10:05:07 -0000
***************
*** 299,305 ****
  	(list url (buffer-size)))
      (mm-url-load-url)
      (let ((name buffer-file-name)
- 	  (url-request-extra-headers (list (cons "Connection" "Close")))
  	  (url-package-name (or mm-url-package-name
  				url-package-name))
  	  (url-package-version (or mm-url-package-version
--- 299,304 ----

[-- Attachment #3: Type: text/plain, Size: 18 bytes --]


regards,
andreas

Re: nnweb vs. mm-url

[Lars Magne Ingebrigtsen]

Andreas Seltenreich <andreas+ding@gate450.dyndns.org> writes:

> does anyone know why mm-url is explicitly setting a "Connection"
> header on all requests? The ChangeLog doesn't contain any hints why it
> was added. 

Neither did the CVS repository.  It looks like it was added by Jesper
Harder, as far as I can see.  Jesper?

I've applied your patch.

-- 
(domestic pets only, the antidote for overdose, milk.)
  larsi@gnus.org * Lars Magne Ingebrigtsen

Re: nnweb vs. mm-url

[Andreas Seltenreich]

Lars Magne Ingebrigtsen <larsi@gnus.org> writes:

> Andreas Seltenreich <andreas+ding@gate450.dyndns.org> writes:
>
>> does anyone know why mm-url is explicitly setting a "Connection"
>> header on all requests? The ChangeLog doesn't contain any hints why it
>> was added. 
>
> Neither did the CVS repository.  It looks like it was added by Jesper
> Harder, as far as I can see.  Jesper?
>
> I've applied your patch.

I guess I found the reason it was added: Versions of url included in
w3 (4.0pre.2001.10.27-16) seem to get stuck when following redirects
without it. I've now made the workaround conditional via url-version
instead of removing it.

regards,
andreas