From mboxrd@z Thu Jan  1 00:00:00 1970
X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/61126
Path: news.gmane.org!not-for-mail
From: Chong Yidong <cyd@stupidchicken.com>
Newsgroups: gmane.emacs.gnus.general
Subject: spam.el not saving spam-stat dictionary
Date: Fri, 07 Oct 2005 21:39:18 -0400
Message-ID: <873bncpz21.fsf@stupidchicken.com>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: sea.gmane.org 1128915207 17124 80.91.229.2 (10 Oct 2005 03:33:27 GMT)
X-Complaints-To: usenet@sea.gmane.org
NNTP-Posting-Date: Mon, 10 Oct 2005 03:33:27 +0000 (UTC)
Original-X-From: ding-owner+m9657@lists.math.uh.edu Mon Oct 10 05:33:24 2005
Return-path: <ding-owner+m9657@lists.math.uh.edu>
Original-Received: from malifon.math.uh.edu ([129.7.128.13])
	by ciao.gmane.org with esmtp (Exim 4.43)
	id 1EOoNe-0001AF-8j
	for ding-account@gmane.org; Mon, 10 Oct 2005 05:31:14 +0200
Original-Received: from localhost
	([127.0.0.1] helo=lists.math.uh.edu ident=lists)
	by malifon.math.uh.edu with smtp (Exim 3.20 #1)
	id 1EOoNR-0000Cn-00; Sun, 09 Oct 2005 22:31:01 -0500
Original-Received: from nas01.math.uh.edu ([129.7.128.39])
	by malifon.math.uh.edu with esmtp (Exim 3.20 #1)
	id 1EO3gK-0003kY-00
	for ding@lists.math.uh.edu; Fri, 07 Oct 2005 20:39:24 -0500
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by nas01.math.uh.edu with esmtp (Exim 4.52)
	id 1EO3gG-0007eO-PO
	for ding@lists.math.uh.edu; Fri, 07 Oct 2005 20:39:24 -0500
Original-Received: from sydneypacific-four-seventy-one.mit.edu ([18.95.6.216] helo=localhost.localdomain)
	by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian))
	id 1EO3gB-00039S-00
	for <ding@gnus.org>; Sat, 08 Oct 2005 03:39:15 +0200
Original-Received: by localhost.localdomain (Postfix, from userid 1000)
	id 4F09B1E4448; Fri,  7 Oct 2005 21:39:18 -0400 (EDT)
Original-To: ding@gnus.org
X-Spam-Score: -2.6 (--)
Precedence: bulk
Original-Sender: ding-owner@lists.math.uh.edu
Xref: news.gmane.org gmane.emacs.gnus.general:61126
Archived-At: <http://permalink.gmane.org/gmane.emacs.gnus.general/61126>

I've been trying to set up the spam-stat spam filtering library, and I
noticed that the new emails I receive aren't being saved into the
spam-stat dictionary.  From what I gather, emails that I mark as spam
are supposed to be "taught" to the dictionary as spam, and the rest of
the email as ham.  In practice, ~/.spam-stat.el hasn't changed since I
first initialized it.


After digging around, I found the follow suspicious code in
`spam-summary-prepare-exit':


	    (dolist (article changed-articles)
	      (let ((id (spam-fetch-field-message-id-fast article)))
		(when (spam-log-unregistration-needed-p
		       id 'process classification check)
		  (push article unregister-list))))
	    (when (and unregister-list (symbol-value check))
	      (spam-register-routine classification check t unregister-list)

The call to spam-register-routine is intended to save the article's
contents to the spam-stat dictionary.

However, in practice unregister-list is always nil, because
spam-log-unregistration-needed-p is defined as

  (defun spam-log-unregistration-needed-p (id type classification check)
    (when spam-log-to-registry
  	....))

And spam-log-to-registry defaults to nil.  Nothing ever gets pushed
onto unregister-list, and spam-register-routine is never called!
Surely this can't be the intended result?