Gnus development mailing list
 help / color / mirror / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Romain Francoise <romain@orebokech.com>, chardhros@oneccuva.org
Subject: Re: exiting summary buffer does not move cursor in group buffer any
Date: Wed, 02 Feb 2005 23:33:18 -0500	[thread overview]
Message-ID: <873bwenu15.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87vf9gysxu.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Sat, 29 Jan 2005 17:32:25 -0500")

Any news?  Is the patch helping at all?


        Stefan


>>>>> "Stefan" == Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>> After experimentation, I have narrowed down the seeming cause of this
>>> problem: This happens if the group buffer is visible when exiting the
>>> summary buffer.

>> Good catch, this is caused by the following change:

>> 2004-11-22  Stefan Monnier  <monnier@iro.umontreal.ca>

>> * gnus-sum.el (gnus-summary-exit): Remove redundant and harmful
>> pop-to-buffer, covered by the subsequent gnus-configure-windows.

>> When the group buffer is already visible the value of point in the
>> buffer is now reset to the window's value when we reselect it; before
>> this change we called pop-to-buffer which displayed the group buffer in
>> the selected window (the one displaying the summary buffer) and ensured
>> that the move was taken into account...

>> I don't remember why Stefan made that change and why pop-to-buffer was
>> harmful here... let's CC him.

> When pop-to-frame is non-nil and the *Group* buffer is not visible,
> pop-to-buffer creates a new frame and takes the careful window management
> off-guard.

> Does the patch below solve the problem?


>         Stefan


> --- gnus-sum.el	04 jan 2005 14:46:56 -0500	1.56
> +++ gnus-sum.el	29 jan 2005 17:31:08 -0500	
> @@ -6680,9 +6680,9 @@
>        (set-buffer gnus-group-buffer)
>        (if quit-config
>  	  (gnus-handle-ephemeral-exit quit-config)
> -	(goto-char group-point)
>  	(unless leave-hidden
> -	  (gnus-configure-windows 'group 'force)))
> +	  (gnus-configure-windows 'group 'force))
> +	(goto-char group-point))
>        ;; Clear the current group name.
>        (unless quit-config
>  	(setq gnus-newsgroup-name nil)))))



  parent reply	other threads:[~2005-02-03  4:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-24 11:39 exiting summary buffer does not move cursor in group buffer any more Jani Grönberg
2005-01-24 14:58 ` Romain Francoise
2005-01-25 18:26   ` Jani Grönberg
2005-01-28 13:17     ` Jani Grönberg
2005-01-29 12:35       ` Romain Francoise
2005-01-29 22:32         ` exiting summary buffer does not move cursor in group buffer any Stefan Monnier
2005-01-29 23:01           ` Romain Francoise
2005-02-03  4:33           ` Stefan Monnier [this message]
     [not found]             ` <m3hdktlqrm.fsf@tanelorn.pacius.net>
2005-02-03 15:47               ` Romain Francoise
2005-02-03 19:04                 ` Jani Grönberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=873bwenu15.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=chardhros@oneccuva.org \
    --cc=romain@orebokech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).