Re: [PATCH 0/2] Simpler authentication with SASL

[Albert Krewinkel <tarleb@moltkeplatz.de>]

Thank you for your answer!

Daiki Ueno <ueno@gnu.org> writes:

> Thanks for the patches.  However, as sasl.el is also distributed as part
> of Emacs (under lisp/net/), you can't simply rename the API functions.

Ah yes, I should have thought of that.  Some quick searching reveals
that there are programs (e.g. the emacs jabber library) which rely on
the current SASL API.  I'm going to prepare a new patch with smaller,
non-API-breaking changes.

> Also, the 1/2 patch looks too large to review.
>
> I'd suggest to work with Emacs rather than Gnus and do the things step
> by step:
>
> (1) write unit tests so not to break the core functionality
>
> (2) refactor the code (without breaking the API), say, using
>     cl-defstruct; you can rename the constructor with :constructor
>     keyword
>
> (3) add handy helper functions e.g. sasl-authenticate

That sounds reasonable, I will follow that path.

Thanks

-- 
Albert Krewinkel
PGP: ffb8 abfa 1fd7 dbd8 b608  c980 836b e330 4b5b 9312