From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/83829 Path: news.gmane.org!not-for-mail From: Albert Krewinkel Newsgroups: gmane.emacs.gnus.general Subject: Re: [PATCH 0/2] Simpler authentication with SASL Date: Tue, 29 Oct 2013 15:21:44 +0100 Organization: Moltkeplatz WG Message-ID: <874n80tax3.fsf@caffelatte.moltkeplatz.de> References: <1382784881-16736-1-git-send-email-tarleb@moltkeplatz.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1383056591 11416 80.91.229.3 (29 Oct 2013 14:23:11 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 29 Oct 2013 14:23:11 +0000 (UTC) Cc: ding@gnus.org To: Daiki Ueno Original-X-From: ding-owner+M32085@lists.math.uh.edu Tue Oct 29 15:23:14 2013 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1VbACP-0002zp-Ca for ding-account@gmane.org; Tue, 29 Oct 2013 15:23:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1VbABG-00014l-Vj; Tue, 29 Oct 2013 09:22:03 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1VbABF-00014b-Ar for ding@lists.math.uh.edu; Tue, 29 Oct 2013 09:22:01 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1:AES128-SHA:128) (Exim 4.76) (envelope-from ) id 1VbAB4-0005Y3-BD for ding@lists.math.uh.edu; Tue, 29 Oct 2013 09:22:00 -0500 Original-Received: from moltkeplatz.de ([85.214.95.47]) by quimby.gnus.org with esmtp (Exim 4.80) (envelope-from ) id 1VbAB2-0008PC-9K for ding@gnus.org; Tue, 29 Oct 2013 15:21:48 +0100 Original-Received: from caffelatte.moltkeplatz.de (dslb-188-096-172-117.pools.arcor-ip.net [188.96.172.117]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by moltkeplatz.de (Postfix) with ESMTPSA id D45AD3200002; Tue, 29 Oct 2013 15:21:45 +0100 (CET) In-Reply-To: (Daiki Ueno's message of "Mon, 28 Oct 2013 16:02:55 +0900") User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3 (gnu/linux) X-Spam-Score: -2.4 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:83829 Archived-At: Thank you for your answer! Daiki Ueno writes: > Thanks for the patches. However, as sasl.el is also distributed as part > of Emacs (under lisp/net/), you can't simply rename the API functions. Ah yes, I should have thought of that. Some quick searching reveals that there are programs (e.g. the emacs jabber library) which rely on the current SASL API. I'm going to prepare a new patch with smaller, non-API-breaking changes. > Also, the 1/2 patch looks too large to review. > > I'd suggest to work with Emacs rather than Gnus and do the things step > by step: > > (1) write unit tests so not to break the core functionality > > (2) refactor the code (without breaking the API), say, using > cl-defstruct; you can rename the constructor with :constructor > keyword > > (3) add handy helper functions e.g. sasl-authenticate That sounds reasonable, I will follow that path. Thanks -- Albert Krewinkel PGP: ffb8 abfa 1fd7 dbd8 b608 c980 836b e330 4b5b 9312