Gnus development mailing list
 help / color / mirror / Atom feed
From: XeCycle <xecycle@gmail.com>
To: ding@gnus.org
Subject: Re: Inconsistency between `mml2015-use' and `mml2015-verify-function'
Date: Sat, 27 Aug 2011 08:26:48 +0800	[thread overview]
Message-ID: <874o13r96f.fsf@gmail.com> (raw)
In-Reply-To: <87wrdz69bp.fsf-ueno@unixuser.org>

Daiki Ueno <ueno@unixuser.org> writes:

[...]

> It looks your color-theme.el is too old.  There is a change not defining
> replace-in-string, which is available in 6.6.0 release:
>
> http://bzr.savannah.gnu.org/lh/color-theme/trunk/revision/55

Thank you for pointing this out.  But they didn't seem to fix it in the
release, so I just modified it myself.

> Anyway, I'll install the attached fix in Gnus side as well since mml2015
> usage of mm-replace-in-string does not really need the 4th arg.
>
>
> === modified file 'lisp/gnus/mml2015.el'
> --- lisp/gnus/mml2015.el	2011-06-30 23:27:10 +0000
> +++ lisp/gnus/mml2015.el	2011-08-26 23:27:42 +0000
> @@ -923,7 +923,7 @@
>  	(mm-set-handle-multipart-parameter
>  	 mm-security-handle 'gnus-info "Corrupted")
>  	(throw 'error handle))
> -      (setq part (mm-replace-in-string part "\n" "\r\n" t)
> +      (setq part (mm-replace-in-string part "\n" "\r\n")
>  	    signature (mm-get-part signature)
>  	    context (epg-make-context))
>        (condition-case error

After all it was solved, I don't want to change this.  If there's
another application using `replace-in-string' which needs the 4th arg,
this change will be useless.

-- 
Carl Lei (XeCycle)
Department of Physics, Shanghai Jiao Tong University
OpenPGP public key: 7795E591
Fingerprint: 1FB6 7F1F D45D F681 C845 27F7 8D71 8EC4 7795 E591




  reply	other threads:[~2011-08-27  0:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-25 12:49 XeCycle
2011-08-25 20:45 ` Daiki Ueno
2011-08-26  1:42   ` XeCycle
2011-08-26  2:00     ` Daiki Ueno
2011-08-26  7:57       ` XeCycle
2011-08-26  9:04         ` Daiki Ueno
2011-08-26 10:44           ` XeCycle
2011-08-26 14:06           ` XeCycle
2011-08-26 23:29             ` Daiki Ueno
2011-08-27  0:26               ` XeCycle [this message]
2011-09-10 22:10             ` Lars Magne Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874o13r96f.fsf@gmail.com \
    --to=xecycle@gmail.com \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).