From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/79753 Path: news.gmane.org!not-for-mail From: XeCycle Newsgroups: gmane.emacs.gnus.general Subject: Re: Inconsistency between `mml2015-use' and `mml2015-verify-function' Date: Sat, 27 Aug 2011 08:26:48 +0800 Message-ID: <874o13r96f.fsf@gmail.com> References: <87ipplwt9l.fsf@gmail.com> <87bovd5ift.fsf-ueno@unixuser.org> <87ei09hrtb.fsf@gmail.com> <877h6038qg.fsf@gmail.com> <87liugtgh4.fsf@gmail.com> <87wrdz69bp.fsf-ueno@unixuser.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1314404860 10076 80.91.229.12 (27 Aug 2011 00:27:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 27 Aug 2011 00:27:40 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M28047@lists.math.uh.edu Sat Aug 27 02:27:35 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Qx6kH-0006Dd-Qx for ding-account@gmane.org; Sat, 27 Aug 2011 02:27:34 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Qx6jz-00074v-9H; Fri, 26 Aug 2011 19:27:15 -0500 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Qx6jx-00074f-LJ for ding@lists.math.uh.edu; Fri, 26 Aug 2011 19:27:13 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.76) (envelope-from ) id 1Qx6jw-0000B8-8A for ding@lists.math.uh.edu; Fri, 26 Aug 2011 19:27:13 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1Qx6jt-0008OB-Cr for ding@gnus.org; Sat, 27 Aug 2011 02:27:09 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Qx6js-00067O-2U for ding@gnus.org; Sat, 27 Aug 2011 02:27:08 +0200 Original-Received: from 59.78.37.25 ([59.78.37.25]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 27 Aug 2011 02:27:07 +0200 Original-Received: from xecycle by 59.78.37.25 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 27 Aug 2011 02:27:07 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 38 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 59.78.37.25 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) Cancel-Lock: sha1:+1j9UBGhflcRvWGesmND7g1cmbE= X-Spam-Score: -1.7 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:79753 Archived-At: Daiki Ueno writes: [...] > It looks your color-theme.el is too old. There is a change not defining > replace-in-string, which is available in 6.6.0 release: > > http://bzr.savannah.gnu.org/lh/color-theme/trunk/revision/55 Thank you for pointing this out. But they didn't seem to fix it in the release, so I just modified it myself. > Anyway, I'll install the attached fix in Gnus side as well since mml2015 > usage of mm-replace-in-string does not really need the 4th arg. > > > === modified file 'lisp/gnus/mml2015.el' > --- lisp/gnus/mml2015.el 2011-06-30 23:27:10 +0000 > +++ lisp/gnus/mml2015.el 2011-08-26 23:27:42 +0000 > @@ -923,7 +923,7 @@ > (mm-set-handle-multipart-parameter > mm-security-handle 'gnus-info "Corrupted") > (throw 'error handle)) > - (setq part (mm-replace-in-string part "\n" "\r\n" t) > + (setq part (mm-replace-in-string part "\n" "\r\n") > signature (mm-get-part signature) > context (epg-make-context)) > (condition-case error After all it was solved, I don't want to change this. If there's another application using `replace-in-string' which needs the 4th arg, this change will be useless. -- Carl Lei (XeCycle) Department of Physics, Shanghai Jiao Tong University OpenPGP public key: 7795E591 Fingerprint: 1FB6 7F1F D45D F681 C845 27F7 8D71 8EC4 7795 E591