From: Antoine Levitt <antoine.levitt@gmail.com>
To: ding@gnus.org
Subject: Re: message-yank-original issue
Date: Tue, 29 Mar 2011 07:37:08 +0200 [thread overview]
Message-ID: <874o6mcwsb.fsf@gmail.com> (raw)
In-Reply-To: <jwv7hbjkmry.fsf-monnier+INBOX@gnu.org>
28/03/11 22:35, Stefan Monnier
>> I'm not sure what's going on with message.el. It clearly says
>
>> (eval-when-compile
>> (require 'cl))
>
>> so it should not be erroring out. Stefan wanted to go back to using
>> `case' instead of `cond' so I'll defer to him.
>
> I see what's going on:
>
> (defun message-yank-original (&optional arg)
> [...]
> (eval
> `(let ,message-cite-style
> [...]
> (case message-cite-reply-position
> [...]
>
>
> Now, why on earth is this code using the evil `eval'?
>
>
> Stefan
Ah, that's my fault. I didn't know how to do it any other way
(message-cite-style contains a let-style list of attributes, so this
seemed like a natural way to do it). I used eval and mentioned the code
might use some improvment, but nobody touched it. What's the preferred
way to do this?
next prev parent reply other threads:[~2011-03-29 5:37 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 10:11 Gnus bugfixing is broken David Kastrup
2011-03-14 14:47 ` Lars Magne Ingebrigtsen
2011-03-14 15:17 ` David Kastrup
2011-03-14 16:12 ` Adam Sjøgren
2011-03-14 17:47 ` Sivaram Neelakantan
2011-03-14 16:22 ` Lars Magne Ingebrigtsen
2011-03-14 19:13 ` message-yank-original issue (was: Gnus bugfixing is broken.) Ted Zlatanov
2011-03-14 19:38 ` message-yank-original issue Antoine Levitt
2011-03-14 19:47 ` Ted Zlatanov
2011-03-14 21:02 ` Antoine Levitt
2011-03-14 22:04 ` Ted Zlatanov
2011-03-15 0:36 ` Michael Welsh Duggan
2011-03-15 15:30 ` Lars Magne Ingebrigtsen
2011-03-15 15:29 ` Lars Magne Ingebrigtsen
2011-03-15 15:49 ` Ted Zlatanov
2011-03-15 15:56 ` Lars Magne Ingebrigtsen
2011-03-15 9:34 ` Ted Zlatanov
2011-03-15 9:48 ` David Kastrup
2011-03-15 10:01 ` Ted Zlatanov
2011-03-26 19:34 ` Sven Joachim
2011-03-28 19:05 ` Ted Zlatanov
2011-03-28 19:57 ` Sven Joachim
2011-03-28 20:06 ` Ted Zlatanov
2011-03-28 20:35 ` Stefan Monnier
2011-03-29 5:37 ` Antoine Levitt [this message]
2011-03-28 20:41 ` Stefan Monnier
2011-03-29 14:55 ` Ted Zlatanov
2011-03-29 15:08 ` David Kastrup
2011-03-29 15:20 ` Gnus compatibility with the lexical binding branch (was: message-yank-original issue) Ted Zlatanov
2011-03-29 20:16 ` Gnus compatibility with the lexical binding branch Stefan Monnier
2011-03-29 20:53 ` Ted Zlatanov
2011-03-30 0:42 ` Stefan Monnier
2011-04-08 5:51 ` Ted Zlatanov
2011-03-15 10:06 ` Gnus bugfixing is broken Ted Zlatanov
2011-03-15 13:31 ` Didier Verna
2011-03-15 13:52 ` Ted Zlatanov
2011-03-15 15:23 ` Lars Magne Ingebrigtsen
2011-03-15 15:56 ` Ted Zlatanov
2011-03-15 16:09 ` Lars Magne Ingebrigtsen
2011-03-15 17:01 ` Didier Verna
2011-03-15 13:58 ` Michael Albinus
2011-03-15 14:46 ` Didier Verna
2011-03-15 14:57 ` Ted Zlatanov
2011-03-15 15:08 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874o6mcwsb.fsf@gmail.com \
--to=antoine.levitt@gmail.com \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).