From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/78145 Path: news.gmane.org!not-for-mail From: Antoine Levitt Newsgroups: gmane.emacs.gnus.general Subject: Re: message-yank-original issue Date: Tue, 29 Mar 2011 07:37:08 +0200 Message-ID: <874o6mcwsb.fsf@gmail.com> References: <871v2ako4c.fsf@fencepost.gnu.org> <87lj0ha52s.fsf@lifelogs.com> <87y64g6833.fsf@lifelogs.com> <87ei5tzneu.fsf@turtle.gmx.de> <877hbjkquz.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1301377130 20271 80.91.229.12 (29 Mar 2011 05:38:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 Mar 2011 05:38:50 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M26456@lists.math.uh.edu Tue Mar 29 07:38:46 2011 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q4Rde-0003Nw-9Q for ding-account@gmane.org; Tue, 29 Mar 2011 07:38:46 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1Q4RcU-00089b-Se; Tue, 29 Mar 2011 00:37:34 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1Q4RcR-00089K-Ja for ding@lists.math.uh.edu; Tue, 29 Mar 2011 00:37:31 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtp (Exim 4.72) (envelope-from ) id 1Q4RcH-0006Gg-KW for ding@lists.math.uh.edu; Tue, 29 Mar 2011 00:37:22 -0500 Original-Received: from lo.gmane.org ([80.91.229.12]) by quimby.gnus.org with esmtp (Exim 4.72) (envelope-from ) id 1Q4RcG-0008EU-8t for ding@gnus.org; Tue, 29 Mar 2011 07:37:20 +0200 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Q4RcG-0002tm-6l for ding@gnus.org; Tue, 29 Mar 2011 07:37:20 +0200 Original-Received: from ney92-7-78-233-218-202.fbx.proxad.net ([78.233.218.202]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Mar 2011 07:37:20 +0200 Original-Received: from antoine.levitt by ney92-7-78-233-218-202.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 29 Mar 2011 07:37:20 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 30 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: ney92-7-78-233-218-202.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-Spam-Score: -1.0 (-) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:78145 Archived-At: 28/03/11 22:35, Stefan Monnier >> I'm not sure what's going on with message.el. It clearly says > >> (eval-when-compile >> (require 'cl)) > >> so it should not be erroring out. Stefan wanted to go back to using >> `case' instead of `cond' so I'll defer to him. > > I see what's going on: > > (defun message-yank-original (&optional arg) > [...] > (eval > `(let ,message-cite-style > [...] > (case message-cite-reply-position > [...] > > > Now, why on earth is this code using the evil `eval'? > > > Stefan Ah, that's my fault. I didn't know how to do it any other way (message-cite-style contains a let-style list of attributes, so this seemed like a natural way to do it). I used eval and mentioned the code might use some improvment, but nobody touched it. What's the preferred way to do this?