Gnus development mailing list
 help / color / mirror / Atom feed
From: Ralf Angeli <angeli@caeruleus.net>
To: ding@gnus.org
Subject: Spurious line inserted if mm-uu-hide-markers is nil
Date: Sat, 20 Nov 2010 22:00:49 +0100	[thread overview]
Message-ID: <874obbg16m.fsf@caeruleus.net> (raw)

Hi,

if you set `mm-uu-hide-markers' to nil as to not lose stuff like
verbatim marks when replying to a message, then a spurious empty line is
inserted in front of a region marked with `message-mark-inserted-region'
such as this:

--8<---------------cut here---------------start------------->8---
foo
--8<---------------cut here---------------end--------------->8---

The empty line is fontified with the face `mm-uu-extract'.

The issue goes away if you apply the following patch:

--- lisp/gnus/mm-uu.el	2010-09-02 01:42:32 +0000
+++ lisp/gnus/mm-uu.el	2010-11-20 20:36:07 +0000
@@ -165,7 +165,7 @@
      ;; dependency on `message.el'.
      "^-+[8<>]*-\\{9,\\}[a-z ]+-\\{9,\\}[a-z ]+-\\{9,\\}[8<>]*-+$"
      "^-+[8<>]*-\\{9,\\}[a-z ]+-\\{9,\\}[a-z ]+-\\{9,\\}[8<>]*-+$"
-     (lambda () (mm-uu-verbatim-marks-extract -1 0 1 -1))
+     (lambda () (mm-uu-verbatim-marks-extract 0 0 1 -1))
      nil)
     ;; Omitting [a-z8<] leads to false positives (bogus signature separators
     ;; and mailing list banners).


Does anybody know if the -1 for the `start-offset' parameter of
`mm-uu-verbatim-marks-extract' has been used on purpose, i.e. would the
change have any negative effects?  If not and if there are no
objections, I'd apply it in Emacs' Bazaar repository.

-- 
Ralf



             reply	other threads:[~2010-11-20 21:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-20 21:00 Ralf Angeli [this message]
2010-11-21  4:25 ` Lars Magne Ingebrigtsen
2010-11-21  7:34   ` Ralf Angeli
2010-11-21  7:41     ` Lars Magne Ingebrigtsen
2010-11-21  8:52       ` Ralf Angeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874obbg16m.fsf@caeruleus.net \
    --to=angeli@caeruleus.net \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).