From: Sven Joachim <svenjoac@gmx.de>
To: ding@gnus.org
Subject: Re: [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value.
Date: Tue, 09 Nov 2010 08:44:27 +0100 [thread overview]
Message-ID: <874obr9c10.fsf@turtle.gmx.de> (raw)
In-Reply-To: <E1PFdVw-0007jE-00@quimby.gnus.org> (Katsumi Yamaoka's message of "Tue, 09 Nov 2010 03:00:48 +0100")
On 2010-11-09 03:00 +0100, Katsumi Yamaoka wrote:
> diff --git a/lisp/message.el b/lisp/message.el
> index 9b5f63c..035ba1c 100644
> --- a/lisp/message.el
> +++ b/lisp/message.el
> @@ -341,14 +341,14 @@ It is okay to create some false positives here, as the user is asked."
> :type 'regexp)
>
> (defcustom message-subject-trailing-was-regexp
> - "[ \t]*\\((*[Ww][Aa][Ss]:[ \t]*.*)\\)"
> + "[ \t]*\\((*[Ww][Aa][Ss][ \t]*.*)\\)"
> "*Regexp matching \"(was: <old subject>)\" in the subject line.
This looks suspicious. The new value of
message-subject-trailing-was-regexp matches neither the docstring nor
what message-change-subject inserts when you change subject. I would
suggest an optional colon both here and in
message-subject-trailing-was-ask-regexp:
--8<---------------cut here---------------start------------->8---
diff --git a/lisp/message.el b/lisp/message.el
index 035ba1c..3dd4464 100644
--- a/lisp/message.el
+++ b/lisp/message.el
@@ -326,7 +326,7 @@ used."
:group 'message-various)
(defcustom message-subject-trailing-was-ask-regexp
- "[ \t]*\\([[(]+[Ww][Aa][Ss][ \t]*.*[\])]+\\)"
+ "[ \t]*\\([[(]+[Ww][Aa][Ss]:?[ \t]*.*[\])]+\\)"
"*Regexp matching \"(was: <old subject>)\" in the subject line.
The function `message-strip-subject-trailing-was' uses this regexp if
@@ -335,13 +335,13 @@ the variable is t instead of `ask', use
`message-subject-trailing-was-regexp' instead.
It is okay to create some false positives here, as the user is asked."
- :version "22.1"
+ :version "24.1"
:group 'message-various
:link '(custom-manual "(message)Message Headers")
:type 'regexp)
(defcustom message-subject-trailing-was-regexp
- "[ \t]*\\((*[Ww][Aa][Ss][ \t]*.*)\\)"
+ "[ \t]*\\((*[Ww][Aa][Ss]:?[ \t]*.*)\\)"
"*Regexp matching \"(was: <old subject>)\" in the subject line.
If `message-subject-trailing-was-query' is set to t, the subject is
--8<---------------cut here---------------end--------------->8---
Cheers,
Sven
next parent reply other threads:[~2010-11-09 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1PFdVw-0007jE-00@quimby.gnus.org>
2010-11-09 7:44 ` Sven Joachim [this message]
2010-11-09 8:16 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing- Katsumi Yamaoka
2010-11-09 17:52 ` [gnus git] branch master updated: =1= message.el (message-subject-trailing-was-regexp): Fix default value Andreas Schwab
2010-11-09 18:11 ` Lars Magne Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874obr9c10.fsf@turtle.gmx.de \
--to=svenjoac@gmx.de \
--cc=ding@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).