Allow message-default-headers to be a function (was: [gnus git] branch master updated: =1= message: Allow message-default-headers to be a function)

Allow message-default-headers to be a function (was: [gnus git] branch master updated: =1= message: Allow message-default-headers to be a function)

[Reiner Steib]

> +2010-10-21  Julien Danjou  <julien@danjou.info>
> +
> +	* message.el (message-setup-1): Allow message-default-headers to be a
> +	function.
> +

> --- a/lisp/message.el
> +++ b/lisp/message.el
> @@ -1183,9 +1183,10 @@ It is a vector of the following headers:
>    :error "All header lines must be newline terminated")
>
>  (defcustom message-default-headers ""
> -  "*A string containing header lines to be inserted in outgoing messages.
> -It is inserted before you edit the message, so you can edit or delete
> -these lines."
> +  "A string containing header lines to be inserted in outgoing messages.
> +It is inserted before you edit the message, so you can edit or
> +delete these lines.  If set to a function, it is called and its
> +result is inserted."

If it can be a string or a function, the first line of the doc string
should not say "A string".  Same for the manual:

> --- a/texi/message.texi
> +++ b/texi/message.texi
> @@ -1451,7 +1451,7 @@ Allegedly.
>  @item message-default-headers
>  @vindex message-default-headers
>  This string is inserted at the end of the headers in all message
> -buffers.
> +buffers.  If set to a function, the returned results is inserted.

,----
| (defcustom message-default-headers ""
|   "A string containing header lines to be inserted in outgoing messages.
| It is inserted before you edit the message, so you can edit or
| delete these lines.  If set to a function, it is called and its
| result is inserted."
|   :version "23.2"
|   :group 'message-headers
|   :link '(custom-manual "(message)Message Headers")
|   :type 'message-header-lines)
`----

The custom type is wrong now, isn't it?  Could you fix it, please?

> --- a/todo
> +++ b/todo
[...]
> -*  allow message-default-headers to be a function.
> -

Could you explain why it is useful?  Is there another reason than "it
was listed in todo"?  ;-)

What about `message-default-mail-headers' and
`message-default-news-headers'?  Should they be changed as well?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Allow message-default-headers to be a function

[Julien Danjou]

On Sat, Oct 23 2010, Reiner Steib wrote:

> If it can be a string or a function, the first line of the doc string
> should not say "A string".  Same for the manual:

Ok, changed.

> The custom type is wrong now, isn't it?  Could you fix it, please?

Done.

> Could you explain why it is useful?  Is there another reason than "it
> was listed in todo"?  ;-)

Not really, but it seemed indeed something that could be useful. :)

> What about `message-default-mail-headers' and
> `message-default-news-headers'?  Should they be changed as well?

I don't think so, you can emulate them from message-default-headers
anyway now that it can be a function.

-- 
Julien Danjou
// ᐰ <julien@danjou.info>   http://julien.danjou.info

Re: Allow message-default-headers to be a function

[Ted Zlatanov]

On Sun, 24 Oct 2010 17:26:05 +0200 Julien Danjou <julien@danjou.info> wrote: 

JD> On Sat, Oct 23 2010, Reiner Steib wrote:

>> Could you explain why it is useful?  Is there another reason than "it
>> was listed in todo"?  ;-)

JD> Not really, but it seemed indeed something that could be useful. :)

For me it's useful.  I currently do it with a custom function on group
entry, so it will be nice to extract that into a cleaner configuration.
But I haven't had the chance to do that extraction yet so I have no
feedback :)

Ted