Re: Sieve gets in infinite loop

[Simon Josefsson <simon@josefsson.org>]

Jason Rumney <jasonr@gnu.org> writes:

> Reiner Steib wrote:
>> On Thu, Nov 19 2009, Jason Rumney wrote:
>>
>>   
>>> My server sends the following non-matching line:
>>>
>>>    OK "Dovecot ready."
>>>     
>>
>> I know next to nothing about sieve, but AFAICS, you (and your server)
>> are right.  Feel free to adjust sieve-manage-parse-capability-1 as
>> needed.
>>   
>
> The following simple patch works for me, but I don't understand why
> the eol needed to be on the regexp in the first place, so I may be
> missing something.
>
> === modified file 'lisp/gnus/sieve-manage.el'
> --- lisp/gnus/sieve-manage.el    2009-01-09 03:01:50 +0000
> +++ lisp/gnus/sieve-manage.el    2010-01-08 14:53:46 +0000
> @@ -636,7 +636,7 @@
>           sieve-manage-capability))
>     (push (list str) sieve-manage-capability))
>       (forward-line)))
> -  (when (re-search-forward (concat "^OK" sieve-manage-server-eol) nil t)
> +  (when (re-search-forward "^OK" nil t)
>     (setq sieve-manage-state 'nonauth)))
>
> (defalias 'sieve-manage-parse-greeting-1 'sieve-manage-parse-capability-1)

According to http://tools.ietf.org/html/draft-ietf-sieve-managesieve-09
the response line can contain an optional string:

    response-nobye        = ("NO" / "BYE") [SP "(" resp-code ")"]
                            [SP string] CRLF
                            ;; The string contains human readable text
                            ;; encoded as UTF-8.

So how about

-  (when (re-search-forward (concat "^OK" sieve-manage-server-eol) nil t)
+  (when (re-search-forward (concat "^OK.*" sieve-manage-server-eol) nil t)

instead?  Not perfect, but hopefully would solve your problem and still
match EOL stuff.

/Simon