Re: bogus function names in sieve-manage

Re: bogus function names in sieve-manage

[Reiner Steib]

On Tue, Dec 23 2008, Dave Love wrote:

> This looks like a simple cut-and-paste-o.  sieve-manage definitely
> shouldn't be defining imap- functions.

Agreed.  Installed.  Does anyone see a problem with the change?

Are the functions necessary at all?  I can't see anything using them.
Simon?

> 2008-12-23  Dave Love  <fx@gnu.org>
>
> 	* sieve-manage.el (sieve-manage-starttls-p): Renamed from
> 	imap-starttls-p.
> 	(sieve-manage-starttls-open): Renamed from imap-starttls-open.
>
> Index: sieve-manage.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/sieve-manage.el,v
> retrieving revision 7.25
> diff -u -F^( -r7.25 sieve-manage.el
> --- sieve-manage.el	17 Sep 2008 11:06:34 -0000	7.25
> +++ sieve-manage.el	23 Dec 2008 15:54:34 -0000
> @@ -304,15 +298,14 @@ (defun sieve-manage-network-open (name b
>        (when (memq (process-status process) '(open run))
>  	process))))
>
> -(defun imap-starttls-p (buffer)
> -  ;;  (and (imap-capability 'STARTTLS buffer)
> +(defun sieve-manage-starttls-p (buffer)
>    (condition-case ()
>        (progn
>  	(require 'starttls)
>  	(call-process "starttls"))
>      (error nil)))
>
> -(defun imap-starttls-open (name buffer server port)
> +(defun sieve-manage-starttls-open (name buffer server port)
>    (let* ((port (or port sieve-manage-default-port))
>  	 (coding-system-for-read sieve-manage-coding-system-for-read)
>  	 (coding-system-for-write sieve-manage-coding-system-for-write)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: bogus function names in sieve-manage

[Dave Love]

Reiner Steib <reinersteib+gmane@imap.cc> writes:

> Are the functions necessary at all?  I can't see anything using them.
> Simon?

`sieve-manage-open' can use them, can't it?  (I don't know anything
about sieve-manage, though.)