Re: fix for time-date.el

[Reiner Steib <reinersteib+gmane@imap.cc>]

On Tue, Dec 23 2008, Dave Love wrote:

> CL is needed for `declare'.  Also note the undefined function -- what is
> that?

Did you test with Emacs 21?  In Emacs 22 and up, declare is a Lisp
macro in `subr.el', assoc-string is a built-in function in
`src/minibuf.c'.

`format-seconds' (where `assoc-string' is used) is not used anywhere
in Gnus so it's not a real problem, AFAICS.  (time-date.el is use in
other parts of Emacs.)

> 2008-12-23  Dave Love  <fx@gnu.org>
>
> 	* time-date.el (cl): Require when compiling.
>
> Index: time-date.el
> ===================================================================
> RCS file: /usr/local/cvsroot/gnus/lisp/time-date.el,v
> retrieving revision 7.16
> diff -u -F^( -r7.16 time-date.el
> --- time-date.el	19 May 2008 08:47:42 -0000	7.16
> +++ time-date.el	23 Dec 2008 15:45:55 -0000
> @@ -39,6 +39,8 @@
>
>  ;;; Code:
>
> +(eval-when-compile (require 'cl))
> +
>  (defmacro with-decoded-time-value (varlist &rest body)
>    "Decode a time value and bind it according to VARLIST, then eval BODY.
>
> @@ -290,6 +292,7 @@ (defun format-seconds (string seconds)
>        (setq start (match-end 0)
>              spec (match-string 1 string))
>        (unless (string-equal spec "%")
> +	;; Fixme: assoc-string not defined.
>          (or (setq match (assoc-string spec units t))
>              (error "Bad format specifier: `%s'" spec))
>          (if (assoc-string spec usedunits t)

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/