From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/67971 Path: news.gmane.org!not-for-mail From: Reiner Steib Newsgroups: gmane.emacs.gnus.general Subject: Re: fix for time-date.el Date: Tue, 23 Dec 2008 17:41:25 +0100 Message-ID: <874p0un8sq.fsf@marauder.physik.uni-ulm.de> References: <87abam99gx.fsf@liv.ac.uk> Reply-To: Reiner Steib NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1230050521 16071 80.91.229.12 (23 Dec 2008 16:42:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Dec 2008 16:42:01 +0000 (UTC) Cc: bugs@gnus.org To: Dave Love , ding@gnus.org Original-X-From: ding-owner+M16417@lists.math.uh.edu Tue Dec 23 17:43:07 2008 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from util0.math.uh.edu ([129.7.128.18]) by lo.gmane.org with esmtp (Exim 4.50) id 1LFALS-0005PW-2A for ding-account@gmane.org; Tue, 23 Dec 2008 17:42:58 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by util0.math.uh.edu with smtp (Exim 4.63) (envelope-from ) id 1LFAK8-0008Jt-Lx; Tue, 23 Dec 2008 10:41:36 -0600 Original-Received: from mx2.math.uh.edu ([129.7.128.33]) by util0.math.uh.edu with esmtps (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1LFAK7-0008Ja-AE for ding@lists.math.uh.edu; Tue, 23 Dec 2008 10:41:35 -0600 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx2.math.uh.edu with esmtp (Exim 4.69) (envelope-from ) id 1LFAK4-00041A-3F for ding@lists.math.uh.edu; Tue, 23 Dec 2008 10:41:35 -0600 Original-Received: from mail.uni-ulm.de ([134.60.1.11]) by quimby.gnus.org with esmtp (Exim 3.36 #1 (Debian)) id 1LFAKH-0001Dk-00; Tue, 23 Dec 2008 17:41:45 +0100 Original-Received: from bridgekeeper.physik.uni-ulm.de (bridgekeeper.physik.uni-ulm.de [134.60.10.175]) by mail.uni-ulm.de (8.14.2/8.14.2) with ESMTP id mBNGfTnJ011206; Tue, 23 Dec 2008 17:41:30 +0100 (MET) Original-Received: from localhost (localhost [127.0.0.1]) by bridgekeeper.physik.uni-ulm.de (Postfix) with ESMTP id 522F81C921; Tue, 23 Dec 2008 17:41:29 +0100 (CET) X-Face: :6KQZ[nyoS_edmB.%gw-=)BYth^|2+Y+^cu%I$FSx!&>-'om>3H7A|M&n(V7fIo3P.;yo.b yq4$p;ZaBtkv)\}biaiBQe"mD}iib1AA@99-fZ7i*bLhNRVC&0Wkxg9)SH?oWc@{ Mail-Followup-To: Dave Love , ding@gnus.org In-Reply-To: <87abam99gx.fsf@liv.ac.uk> (Dave Love's message of "Tue, 23 Dec 2008 15:50:38 +0000") User-Agent: Gnus/5.110011 (No Gnus v0.11) Emacs/22.1 (gnu/linux) X-DCC-CTc-dcc1-Metrics: poseidon 1030; Body=3 Fuz1=3 Fuz2=3 X-Virus-Scanned: by amavisd-new X-Spam-Score: -2.6 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:67971 Archived-At: On Tue, Dec 23 2008, Dave Love wrote: > CL is needed for `declare'. Also note the undefined function -- what is > that? Did you test with Emacs 21? In Emacs 22 and up, declare is a Lisp macro in `subr.el', assoc-string is a built-in function in `src/minibuf.c'. `format-seconds' (where `assoc-string' is used) is not used anywhere in Gnus so it's not a real problem, AFAICS. (time-date.el is use in other parts of Emacs.) > 2008-12-23 Dave Love > > * time-date.el (cl): Require when compiling. > > Index: time-date.el > =================================================================== > RCS file: /usr/local/cvsroot/gnus/lisp/time-date.el,v > retrieving revision 7.16 > diff -u -F^( -r7.16 time-date.el > --- time-date.el 19 May 2008 08:47:42 -0000 7.16 > +++ time-date.el 23 Dec 2008 15:45:55 -0000 > @@ -39,6 +39,8 @@ > > ;;; Code: > > +(eval-when-compile (require 'cl)) > + > (defmacro with-decoded-time-value (varlist &rest body) > "Decode a time value and bind it according to VARLIST, then eval BODY. > > @@ -290,6 +292,7 @@ (defun format-seconds (string seconds) > (setq start (match-end 0) > spec (match-string 1 string)) > (unless (string-equal spec "%") > + ;; Fixme: assoc-string not defined. > (or (setq match (assoc-string spec units t)) > (error "Bad format specifier: `%s'" spec)) > (if (assoc-string spec usedunits t) Bye, Reiner. -- ,,, (o o) ---ooO-(_)-Ooo--- | PGP key available | http://rsteib.home.pages.de/