Gnus development mailing list
 help / color / mirror / Atom feed
From: Daniel Pittman <daniel@rimspace.net>
Cc: Lars Magne Ingebrigtsen <larsi@ifi.uio.no>
Subject: [BUG] gnus-summary-line-format `%4,-4L' fails with CVS gnus.
Date: 09 May 2001 16:23:13 +1000	[thread overview]
Message-ID: <874ruvt5ux.fsf@inanna.rimspace.net> (raw)

In the file `gnus-sum.el', between version 6.60 and 6.61, Lars changed
the type of the `L' format option from a number to a string.

This was done, from reading the diff, to allow "?" to be displayed if
there was no information on the number of lines in a message.

This is a nice change and all, but it broke the handling of maximum size
constraints for the format option.

Specifically, if you specify `%-4L' as a constraint, the following code
is generated in the (semi-)compiled version of the format:

... (if (> 4 (length gnus-tmp-lines)) ...

The problem, of course, is that `gnus-tmp-lines' contains a number if
there was a lines header in the message.

Since `length' will fail (and throw an exception) in this case, this
makes the summary generation fail when this constraint is specified.

I would attach a patch, but I am unsure exactly where the number should
be converted to a string for this to work.

        Daniel

-- 
Psychoanalysis is the mental illness it purports to cure. 
        -- Karl Krauss


                 reply	other threads:[~2001-05-09  6:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874ruvt5ux.fsf@inanna.rimspace.net \
    --to=daniel@rimspace.net \
    --cc=larsi@ifi.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).