From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/36157 Path: main.gmane.org!not-for-mail From: Daniel Pittman Newsgroups: gmane.emacs.gnus.general Subject: [BUG] gnus-summary-line-format `%4,-4L' fails with CVS gnus. Date: 09 May 2001 16:23:13 +1000 Organization: Not today, thank you, Mother. Message-ID: <874ruvt5ux.fsf@inanna.rimspace.net> NNTP-Posting-Host: coloc-standby.netfonds.no Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1035171790 7078 80.91.224.250 (21 Oct 2002 03:43:10 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Mon, 21 Oct 2002 03:43:10 +0000 (UTC) Keywords: number,format Cc: Lars Magne Ingebrigtsen Return-Path: Original-Received: (qmail 6234 invoked by alias); 9 May 2001 06:24:10 -0000 Original-Received: (qmail 6229 invoked from network); 9 May 2001 06:24:09 -0000 Original-Received: from melancholia.rimspace.net (HELO melancholia.danann.net) (203.36.211.210) by gnus.org with SMTP; 9 May 2001 06:24:09 -0000 Original-Received: from localhost (melancholia.rimspace.net [203.36.211.210]) by melancholia.danann.net (Postfix) with ESMTP id 678BC2A820 for ; Wed, 9 May 2001 16:23:51 +1000 (EST) Original-Received: by localhost (Postfix, from userid 1000) id 45BC08214D; Wed, 9 May 2001 16:23:13 +1000 (EST) Original-To: ding@gnus.org X-Homepage: http://danann.net/ X-spies: Project Monarch munitions Ruby Ridge CIA Nazi Kibo class struggle Saddam Hussein Craig Livingstone Kenneth Starr Honduras FSF NSA SDI Peking User-Agent: Gnus/5.090004 (Oort Gnus v0.04) XEmacs/21.5 (alfalfa) Original-Lines: 28 Xref: main.gmane.org gmane.emacs.gnus.general:36157 X-Report-Spam: http://spam.gmane.org/gmane.emacs.gnus.general:36157 In the file `gnus-sum.el', between version 6.60 and 6.61, Lars changed the type of the `L' format option from a number to a string. This was done, from reading the diff, to allow "?" to be displayed if there was no information on the number of lines in a message. This is a nice change and all, but it broke the handling of maximum size constraints for the format option. Specifically, if you specify `%-4L' as a constraint, the following code is generated in the (semi-)compiled version of the format: ... (if (> 4 (length gnus-tmp-lines)) ... The problem, of course, is that `gnus-tmp-lines' contains a number if there was a lines header in the message. Since `length' will fail (and throw an exception) in this case, this makes the summary generation fail when this constraint is specified. I would attach a patch, but I am unsure exactly where the number should be converted to a string for this to work. Daniel -- Psychoanalysis is the mental illness it purports to cure. -- Karl Krauss