Gnus development mailing list
 help / color / mirror / Atom feed
From: Kevin Boulain <kevin@boula.in>
To: ding@gnus.org
Subject: Does gnus-summary-move-article need to clear the marks?
Date: Sat, 07 Jan 2023 21:42:45 +0100	[thread overview]
Message-ID: <875ydirs8q.fsf@boula.in> (raw)

Hey,

I'm trying out Gnus and the IMAP server from which I'm getting my emails
is running a Sieve script that takes some actions, including setting a
bunch of IMAP keywords/flags ('client' ones, not the system ones like
\Seen as per https://www.rfc-editor.org/rfc/rfc3501#section-2.3.2).

When an email with these custom flags is marked as read (via 'd',
gnus-summary-mark-as-read-forward) and moved to another IMAP folder (via
'B m', gnus-summary-move-article) it loses its flags.

In the IMAP log (that I got with nnimap-record-commands) I can see:
  UID STORE 65 FLAGS.SILENT (\Seen)

A quick Edebug breakpoint on nnimap-request-set-mark (where the magic
seems to happen) gives the following backtrace:
  nnimap-request-set-mark("INBOX" (((65) set (read)) ((65) del (unexist seen forward unsend download cache save score dormant bookmark killed expire reply tick))) "$SERVER")
  gnus-request-set-mark("nnimap+$SERVER:INBOX" (((65) set (read)) ((65) del (unexist seen forward unsend download cache save score dormant bookmark killed expire reply tick))))
  gnus-summary-push-marks-to-backend(65)
  gnus-summary-move-article(nil)
  funcall-interactively(gnus-summary-move-article nil)
  command-execute(gnus-summary-move-article)

So the issue appears to be that gnus-summary-push-marks-to-backend calls
gnus-request-set-mark with 'set:
https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/gnus/gnus-sum.el?h=emacs-28.2#n10390

Should it be 'add instead, which should preserve the set of flags?
https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/gnus/nnimap.el?h=emacs-28.2#n1243

Similarly to what marking as read does:
 UID STORE 67 +FLAGS.SILENT (\Seen)
From around here:
https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/gnus/gnus-sum.el?h=emacs-28.2#n12896


             reply	other threads:[~2023-01-11 18:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-07 20:42 Kevin Boulain [this message]
2023-01-11 19:07 ` Kevin Boulain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875ydirs8q.fsf@boula.in \
    --to=kevin@boula.in \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).