Gnus development mailing list
 help / color / mirror / Atom feed
From: Tassilo Horn <tsdh@gnu.org>
To: ding@gnus.org
Subject: Re: How to change definition of gnus-summary-exit?
Date: Fri, 16 Oct 2015 09:19:03 +0200	[thread overview]
Message-ID: <8761275li0.fsf@gnu.org> (raw)
In-Reply-To: <87d1wf4sr0.fsf@vostro.rath.org> (Nikolaus Rath's message of "Thu, 15 Oct 2015 16:27:47 -0700")

Nikolaus Rath <Nikolaus@rath.org> writes:

>> Ah, I see.  Well, then I'd just use the complete git version if I
>> were you.
>
> That's what I'm trying to do. Isn't putting the lisp/ directory from
> the git clone sufficient to achieve that?

Ah, sorry, I had understood that you are trying to use the Gnus version
that comes with Emacs but with the gnus-sum.el that comes with Gnus' git
version.

I also run the Git version of Gnus, and that's what you need to do:

Once: clone the git repo && ./configure && make
Regularly: git pull && make

And in my ~/.emacs there is

  (add-to-list 'load-path "~/Repos/el/gnus/lisp")
  (add-to-list 'Info-directory-list "~/Repos/el/gnus/texi")
  (require 'gnus-load)

which you have to adapt to your Gnus checkout directory accordingly.

>>>> What do you want to change exactly?  Oftentimes, a simple advice
>>>> will do without having to override the complete function.
>>>
>>> What's an advice (in this context)?
>>
>> An advice is a function which is run before, after, instead of, or
>> "around" some other function.  See (info "(elisp)Advising
>> Functions").
>
> Uh, that's pretty cool. It seems I need to do some reading.

Yes, it is.  However, in the current case you could only use

  (advice-add 'gnus-summary-exit :override
              #'your-version-of-gnus-summary-exit)

which would override the normal version with your patched version.  I
guess in this situation, it is better to apply your patch to the git
version, run it for some time, and then report back to the bug report
that nothing breaks (if nothing breaks, of course).  Then someone will
hopefully commit it to Gnus.  If nobody reacts, feel free to ping me, I
have push access.

Bye,
Tassilo



  reply	other threads:[~2015-10-16  7:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-14 17:28 Nikolaus Rath
2015-10-14 18:08 ` Adam Sjøgren
2015-10-15  6:34   ` Tassilo Horn
2015-10-15 17:47     ` Nikolaus Rath
2015-10-15 19:16       ` Tassilo Horn
2015-10-15 23:27         ` Nikolaus Rath
2015-10-16  7:19           ` Tassilo Horn [this message]
2015-10-15 20:17       ` Emanuel Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8761275li0.fsf@gnu.org \
    --to=tsdh@gnu.org \
    --cc=ding@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).