From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/86227 Path: news.gmane.org!not-for-mail From: Tassilo Horn Newsgroups: gmane.emacs.gnus.general Subject: Re: How to change definition of gnus-summary-exit? Date: Fri, 16 Oct 2015 09:19:03 +0200 Message-ID: <8761275li0.fsf@gnu.org> References: <87io69jr5o.fsf@thinkpad.rath.org> <87si5diara.fsf@tullinup.koldfront.dk> <874mhsprmo.fsf@gnu.org> <87eggwvxat.fsf@thinkpad.rath.org> <8737xcndrd.fsf@gnu.org> <87d1wf4sr0.fsf@vostro.rath.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1444980068 13503 80.91.229.3 (16 Oct 2015 07:21:08 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 16 Oct 2015 07:21:08 +0000 (UTC) To: ding@gnus.org Original-X-From: ding-owner+M34461@lists.math.uh.edu Fri Oct 16 09:20:53 2015 Return-path: Envelope-to: ding-account@gmane.org Original-Received: from lists1.math.uh.edu ([129.7.128.208]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZmzJr-0003OL-AM for ding-account@gmane.org; Fri, 16 Oct 2015 09:20:51 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.math.uh.edu) by lists1.math.uh.edu with smtp (Exim 4.85) (envelope-from ) id 1ZmzIV-00015H-8G; Fri, 16 Oct 2015 02:19:27 -0500 Original-Received: from mx1.math.uh.edu ([129.7.128.32]) by lists1.math.uh.edu with esmtps (TLSv1.2:AES128-GCM-SHA256:128) (Exim 4.85) (envelope-from ) id 1ZmzIT-00014z-B2 for ding@lists.math.uh.edu; Fri, 16 Oct 2015 02:19:25 -0500 Original-Received: from quimby.gnus.org ([80.91.231.51]) by mx1.math.uh.edu with esmtps (TLSv1.2:DHE-RSA-AES128-SHA:128) (Exim 4.85) (envelope-from ) id 1ZmzIQ-00014R-F4 for ding@lists.math.uh.edu; Fri, 16 Oct 2015 02:19:25 -0500 Original-Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by quimby.gnus.org with esmtps (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1ZmzIB-0001v1-Ni for ding@gnus.org; Fri, 16 Oct 2015 09:19:13 +0200 Original-Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4DD1E20426 for ; Fri, 16 Oct 2015 03:19:06 -0400 (EDT) Original-Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Fri, 16 Oct 2015 03:19:06 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-sasl-enc :x-sasl-enc; s=smtpout; bh=mZ+tnIA27mh3uPZ1Tc+5lXgtwds=; b=DXkO/ 3xvD3jMCVGkNc7fJTAV2WgjUlTiLiI8e9w3+EKrn1fJKeybGAXjT1/NLl9b+WqIP G27pYOCThSzWg1veOXv5SId/4/lEAIgCBaaBMCRcYRD+6IXNFoWM6KP/F2YRAUWt 7OhxGDXVhH+FOnk6x/3LJSZS4xqZWS14tgIIQQ= X-Sasl-enc: H7vYkDve+Hcvv7QgjAsqj/YvBY+W7OPXZG/Kxp3JmqSQ 1444979945 Original-Received: from thinkpad-t440p (unknown [2.163.5.132]) by mail.messagingengine.com (Postfix) with ESMTPA id 963D8C0001E for ; Fri, 16 Oct 2015 03:19:05 -0400 (EDT) Mail-Followup-To: ding@gnus.org In-Reply-To: <87d1wf4sr0.fsf@vostro.rath.org> (Nikolaus Rath's message of "Thu, 15 Oct 2015 16:27:47 -0700") User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.50 (gnu/linux) X-Spam-Score: -2.3 (--) List-ID: Precedence: bulk Xref: news.gmane.org gmane.emacs.gnus.general:86227 Archived-At: Nikolaus Rath writes: >> Ah, I see. Well, then I'd just use the complete git version if I >> were you. > > That's what I'm trying to do. Isn't putting the lisp/ directory from > the git clone sufficient to achieve that? Ah, sorry, I had understood that you are trying to use the Gnus version that comes with Emacs but with the gnus-sum.el that comes with Gnus' git version. I also run the Git version of Gnus, and that's what you need to do: Once: clone the git repo && ./configure && make Regularly: git pull && make And in my ~/.emacs there is (add-to-list 'load-path "~/Repos/el/gnus/lisp") (add-to-list 'Info-directory-list "~/Repos/el/gnus/texi") (require 'gnus-load) which you have to adapt to your Gnus checkout directory accordingly. >>>> What do you want to change exactly? Oftentimes, a simple advice >>>> will do without having to override the complete function. >>> >>> What's an advice (in this context)? >> >> An advice is a function which is run before, after, instead of, or >> "around" some other function. See (info "(elisp)Advising >> Functions"). > > Uh, that's pretty cool. It seems I need to do some reading. Yes, it is. However, in the current case you could only use (advice-add 'gnus-summary-exit :override #'your-version-of-gnus-summary-exit) which would override the normal version with your patched version. I guess in this situation, it is better to apply your patch to the git version, run it for some time, and then report back to the bug report that nothing breaks (if nothing breaks, of course). Then someone will hopefully commit it to Gnus. If nobody reacts, feel free to ping me, I have push access. Bye, Tassilo