From mboxrd@z Thu Jan 1 00:00:00 1970 X-Msuck: nntp://news.gmane.io/gmane.emacs.gnus.general/86064 Path: news.gmane.org!not-for-mail From: Nikolaus Rath Newsgroups: gmane.emacs.devel,gmane.emacs.gnus.general Subject: bug#21043: [PATCH] nnimap.el: make capability parsing more robust. Date: Sun, 12 Jul 2015 18:52:40 -0700 Message-ID: <87615olt7b.fsf@vostro.rath.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1436752401 30539 80.91.229.3 (13 Jul 2015 01:53:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 13 Jul 2015 01:53:21 +0000 (UTC) Cc: eric@ericabrahamsen.net, ding@gnus.org, emacs-devel@gnu.org To: 21043@debbugs.gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 13 03:53:12 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZESvf-0006Ec-UA for ged-emacs-devel@m.gmane.org; Mon, 13 Jul 2015 03:53:12 +0200 Original-Received: from localhost ([::1]:52518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZESve-0006nv-Sy for ged-emacs-devel@m.gmane.org; Sun, 12 Jul 2015 21:53:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZESvb-0006na-0i for emacs-devel@gnu.org; Sun, 12 Jul 2015 21:53:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZESvX-0000D2-Md for emacs-devel@gnu.org; Sun, 12 Jul 2015 21:53:06 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZESvX-0000Cs-Im for emacs-devel@gnu.org; Sun, 12 Jul 2015 21:53:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZESvV-00077W-V5; Sun, 12 Jul 2015 21:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nikolaus Rath Original-Sender: "Debbugs-submit" Resent-CC: ding@gnus.org, emacs-devel@gnu.org, eric@ericabrahamsen.net, bugs@gnus.org Resent-Date: Mon, 13 Jul 2015 01:53:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 21043 X-GNU-PR-Package: gnus X-GNU-PR-Keywords: patch X-Debbugs-Original-To: submit@debbugs.gnu.org X-Debbugs-Original-Xcc: ding@gnus.org, emacs-devel@gnu.org, eric@ericabrahamsen.net Original-Received: via spool by submit@debbugs.gnu.org id=B.143675236627347 (code B ref -1); Mon, 13 Jul 2015 01:53:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Jul 2015 01:52:46 +0000 Original-Received: from localhost ([127.0.0.1]:47741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZESvG-000770-1r for submit@debbugs.gnu.org; Sun, 12 Jul 2015 21:52:46 -0400 Original-Received: from ebox.rath.org ([23.92.25.96]:46876) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZESvD-00076q-2G for submit@debbugs.gnu.org; Sun, 12 Jul 2015 21:52:43 -0400 Original-Received: from vostro ([192.168.12.4] helo=vostro.rath.org) by ebox.rath.org with esmtps (TLSv1.2:DHE-RSA-AES256-GCM-SHA384:256) (Exim 4.80) (envelope-from ) id 1ZESvB-0007vj-KM for submit@debbugs.gnu.org; Mon, 13 Jul 2015 01:52:41 +0000 Original-Received: by vostro.rath.org (Postfix, from userid 1000) id AAC26EC5EF6; Sun, 12 Jul 2015 18:52:40 -0700 (PDT) User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/24.4 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: emacs-devel@gnu.org List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187842 gmane.emacs.gnus.general:86064 Archived-At: Package: gnus Tags: patch Hello, Currently Gnus relies on the server supplying the capabilities in its response to the LOGIN command, e.g. like this: * CAPABILITY IMAP4rev1 LITERAL+ SASL-IR LOGIN-REFERRALS ID ENABLE IDLE SORT SORT=3DDISPLAY THREAD=3DREFERENCES THREAD=3DREFS THREAD=3DORDEREDSUB= JECT MULTIAPPEND URL-PARTIAL CATENATE UNSELECT CHILDREN NAMESPACE UIDPLUS LIST-EXTENDED I18NLEVEL=3D1 CONDSTORE QRESYNC ESEARCH ESORT SEARCHRES WITHIN CONTEXT=3DSEARCH LIST-STATUS SPECIAL-USE BINARY MOVE SEARCH=3DFUZZY QUOTA\r\n 1 OK Logged in\r\n However, this assumption breaks if the server doesn't return the capabilities automatically, or if he returns them as part of the OK response, e.g.: 160 OK [CAPABILITY IMAP4rev1 LITERAL+ ID ENABLE ACL RIGHTS=3Dkxten QUOTA MAILBOX-REFERRALS NAMESPACE UIDPLUS NO_ATOMIC_RENAME UNSELECT CHILDREN MULTIAPPEND BINARY CATENATE CONDSTORE ESEARCH SEARCH=3DFUZZY SORT SORT=3DMODSEQ SORT=3DDISPLAY SORT=3DUID THREAD=3DORDEREDSUBJECT THREAD=3DREFERENCES ANNOTATEMORE ANNOTATE-EXPERIMENT-1 METADATA LIST-EXTENDED LIST-STATUS LIST-MYRIGHTS LIST-METADATA WITHIN QRESYNC SCAN XLIST XMOVE MOVE SPECIAL-USE CREATE-SPECIAL-USE DIGEST=3DSHA1 X-REPLICATION LOGINDISABLED XCONVERSATIONS COMPRESS=3DDEFLATE X-QUOTA=3DSTORAGE X-QUOTA=3DMESSAGE X-QUOTA=3DX-ANNOTATION-STORAGE X-QUOTA=3DX-NUM-FOLDERS IDLE] User logged in SESSIONID=3D\r\n Currently, in this situation Gnus just keeps re-using the pre-LOGIN capabilities (and thus does not take advantage of any additional features). The attached patch fixes this issue by explicitly asking the server for its capabilities after login. Thanks for considering, -Nikolaus --=20 GPG encrypted emails preferred. Key id: 0xD113FCAC3C4E599F Fingerprint: ED31 791B 2C5C 1613 AF38 8B8A D113 FCAC 3C4E 599F =C2=BBTime flies like an arrow, fruit flies like a Banana.=C2= =AB